4 ms·
That is happening because you are running PHP 7.2. In that file $this->extra_headers is initialized as non-countable NULL. Basically phpBB needs to update the
by Washuu 8y ago
That is happening because you are running PHP 7.2. In that file $this->extra_headers is initialized as non-countable NULL. Basically phpBB needs to update their code base to support newer versions of PHP. A quick fix would be to change "var ... $extra_headers" at the top of the file to "protected $extra_headers = [];".
- Jake232 8y agoIt's probably a safe assumption that they use a similar style elsewhere though, so probably better to just change PHP version rather than edit the source files? I could be wrong, (I'm a Python guy - not PHP), just seems a safe assumption that it's likely not the only spot.
- krapp 8y ago> so probably better to just change PHP version rather than edit the source files? NO. It's better to improve the code than roll back to an older and less secure version of the language. This is PHP we're talking about, after all.
- grandpoobah 8y agoI agree with your logic. Best to just do what jwong_ said and disable warnings.
- sneak 8y agoA quicker fix for a brand new forum would be to not use some janky old PHP codebase.
- dchuk 8y agoThanks for detailing this, I'll get it fixed tonight.
- dchuk 8y agoTo follow up: I think I fixed this, but I don’t have a good way to test. So please let me know if there are other things to investigate