4 ms·

> TODO: this should use scutil and be slightly more clever. But for now we simply overwrite any _manually set_ DNS servers for all network services. This means

by gok 8y ago

> TODO: this should use scutil and be slightly more clever. But for now we simply overwrite any _manually set_ DNS servers for all network services. This means we get into trouble if the user doesn't actually want DNS via DHCP when setting this back to "empty". Because macOS is so horrible to deal with here, we'll simply wait for irate users to provide a patch themselves. [1] So the setup script completely deletes all your manual DNS settings without warning you. [1] https://git.zx2c4.com/WireGuard/tree/src/tools/wg-quick/darwin.bash?id=a0d5736e11e1e70189393fc8803c2c1500c87d3e https://git.zx2c4.com/WireGuard/tree/src/tools/wg-quick/darw...

chatmasta 8y ago
> “now available for testing” Aka it’s alpha software, use at your own risk. Thus, yours seems like an unreasonable criticism. Definitely good to know though.
- gok 8y ago
  Destroying user data without warning is acceptable as long as you say "this is for testing"?
  - chatmasta 8y ago
    Maybe I’m misreading it but I think it only deletes the DNS data while the wireguard connection is active?
    - zx2c4 8y ago
      Before I fixed it, it wouldn't restore the previous non-DHCP-set DNS servers when you took the interface down. Now this bug is fixed.
zx2c4 8y ago
Pointed out on the mailing list, too. Did you make a concerted effort to link to the file revision that doesn't contain the fix for that? Anyway, this is taken care of now, and will be released with the next snapshot. https://git.zx2c4.com/WireGuard/commit/?id=b39298dfb540ad9c751e15585f4b95acb071ca84 https://git.zx2c4.com/WireGuard/commit/?id=b39298dfb540ad9c7...
- gok 8y ago
  Sorry I wasn’t trying to be a dick, all software has bugs, just thought people might want to know before they try it. Thanks for fixing it.