3 ms·
One thing that I ask people on my team to do is only have one set of review comments. What I hate is when you address a bunch of code reviews, and then the same
by pfarnsworth 8y ago
One thing that I ask people on my team to do is only have one set of review comments. What I hate is when you address a bunch of code reviews, and then the same reviewer comes and finds more things to change. Then it's a never-ending cycle of fix and change, fix and change, which wastes everyone's time.
Go through your code review thoroughly, and only make one set of comments. Of course, if you happen to find a huge bug then that necessitates more reviews. However, I think that reflects poorly on the reviewer, she should have spent more time reviewer more carefully the first time.
- zo1 8y agoI found this only to be a problem if the person who wrote the code being reviewed is slow at writing/changing code. It shouldn't be a big deal: Checkout, fix, re-run tests, commit, push, tick off task. However, if the above process on the developer's side is not quick, then no matter if the comments are batched together, the whole thing will take a long time. This is usually a sign that the wrong person is doing this specific module, or that they need more mentoring/training/firing.