3 ms·

Code reviews are hard. It takes a lot of time to really review something and understand it. I think it's much better to discuss plans up front and get buy in fr

Code reviews are hard. It takes a lot of time to really review something and understand it. I think it's much better to discuss plans up front and get buy in from other people before and while you write the code. Obviously that requires an open and respectful culture.

s17n 9y ago
It's good to discuss things upfront but I almost always realize stuff while I'm implementing that I hadn't completely forseen.
- maxxxxx 9y ago
  Let's just say having some continuous dialog while developing is preferable over review after everything is done. I have that kind of relationship with a few people and it works great.
  - ThrustVectoring 9y ago
    In a healthy environment, sure. In an unhealthily micromanaged one, you may want to push the review to the end so that you can document that the review process with this person took an extraordinary amount of time and delayed rollout of a feature.
    - maxxxxx 9y ago
      You are an evil genius :-). and sadly that happens quite a bit.