4 ms·
Just a few days ago, AWS announced[1] that they will be contributing TLS to Redis, and judging by one of his comments[2], antirez doesn't seem to be completely
by piquadrat 8y ago
Just a few days ago, AWS announced[1] that they will be contributing TLS to Redis, and judging by one of his comments[2], antirez doesn't seem to be completely against merging it.
According to a comment on Reddit[3], Josiah wasn't aware of this effort by AWS.
[1]: https://aws.amazon.com/cn/blogs/opensource/open-sourcing-encryption-in-transit-redis/ https://aws.amazon.com/cn/blogs/opensource/open-sourcing-enc...
[2]: https://github.com/antirez/redis/pull/4855#issuecomment-383171007 https://github.com/antirez/redis/pull/4855#issuecomment-3831...
[3]: https://www.reddit.com/r/redis/comments/8f373k/a_new_redis_fork_with_ssl_transactions/dy19br1/ https://www.reddit.com/r/redis/comments/8f373k/a_new_redis_f...
- fapjacks 8y agoNice! At first blush, the TLS PR looks pretty good. It's not just shimmed in there like it could be (for example if I'd have written it haha). I've always appreciated Redis for having generally excellent code quality over the years. Looks like a great contribution to the project!
- DrJosiah 8y agoIt is better than the code I actually wrote, I've already switched to it as a base, and have been merging my changes in to my local branch today. :) I look forward to everyone having SSL :)
- itamarhaber 8y ago> antirez doesn't seem to be completely against merging it First-hand report from the impromptu Friday post-conf devmeet: he's gonna merge it! ;)
- DrJosiah 8y agoIt's really good code. I've switched to it and started applying my other changes on top. I wouldn't use my fork for the SSL, I would consider using my future version for the other features that are not yet ready. :P