4 ms·
is it just me or is the sidebar broken? Selecting a link on the sidebar after getting to the end of a page doesn't reset scrollY position
by wnevets 9y ago
is it just me or is the sidebar broken? Selecting a link on the sidebar after getting to the end of a page doesn't reset scrollY position
- smspillaz 9y agoIt is! I'll fix it later tonight.
- ginnungagap 9y agoAlso maybe it's just my phone but on mobile the sidebar covers the whole website making it impossible to read
- smspillaz 9y agoOh interesting. What phone are you using? It should enter a mobile-friendly kind of view, but I haven't implemented that on the server side renderer yet.
- Jare 9y agoYou may want to consider mobile-friendliness purely client side, using CSS to set up different layouts depending on the resolution - what's typically called Responsive Web Design. Sounds cumbersome, but with just the right couple of design tweaks you may get 90% usability on mobile.
- smspillaz 9y agoActually, I think the issue here now that I think of it is that we do media query detection in on the React side to figure out which components to render. Really, we should just render a single component and have CSS to cover both cases. Other sites do this, so it should be possible, though it would require me to change the react component that renders the sidebar (I'm using Atlaskit, but that doesn't have support for mobile responsive rendering, sadly).