4 ms·
Every function has side effects. Could've written the whole thing in one function. Also, PEP8.
by kpenc 8y ago
Every function has side effects. Could've written the whole thing in one function. Also, PEP8.
- apetresc 8y agoOne function? Could've written the whole thing in one `wget` call.
- pknerd 8y agoteach me how.
- shubb 8y agoI guess wget has a useful spidering function that could probably page through the websites search results page, downloading all the preview and real images. You'd have to do the login bit as a different call and fetch the first search pages url yourself?
- apetresc 8y agoHere's a start: for x in $(curl -s https://alpha.wallhaven.cc/random | pcregrep -o1 "https://alpha.wallhaven.cc/wallpaper/(\d+)" | sort | uniq) ; do wget "https://wallpapers.wallhaven.cc/wallpapers/full/wallhaven-$x.jpg" ; done
- akx 8y agobash, curl, pcregrep, sort, uniq and wget is not what I'd call "one wget call".
- slenk 8y agoTo the hardcore bash users, I think they call that 'easy'. I have someone like that on my team - holy crap some of the bash stuff they can come up with
- zo1 8y agoI hope none of that stuff makes it into your main codebase? If there is even a remote chance of requiring maintenance by someone other than the person that wrote it, that is. Which is probably 99.99% the chance, unless it's temporary/throwaway code.
- lou1306 8y agoHardcore bash sure sounds like fun, but when things start getting too big or messy I usually find a Python script with some `subprocess` [0] tricks to be way easier on the eye. [0]: https://docs.python.org/3/library/subprocess.html https://docs.python.org/3/library/subprocess.html
- mynewtb 8y agoEvery code has side effects. Splitting code into appropriate functions makes those side effects much more managable.