3 ms·
Oh, I completely agree, though I wouldn't call writing code carefully and methodically a "code review" if that makes sense. I personally find that me a couple
by ben-schaaf 9y ago
Oh, I completely agree, though I wouldn't call writing code carefully and methodically a "code review" if that makes sense.
I personally find that me a couple months down the track is pretty much another person anyway. In a sense you're not reviewing your own code, you're letting it be reviewed by future you. But if you're in a team with multiple developers, having someone else review your code would be more efficient.
- _asummers 9y agoI tend to review my code with a reviewer hat, not with the author hat, before I open the PR. Find all the places where I'd call myself out for lazy names, poor abstractions, missing docs, etc. then go in and fix those. Repeat until satisfied, then open PR.