4 ms·
> clearly he had been involved personally in most of the things I was criticizing: code of poor quality with no validation of inputs, lots of partially finishe
by marshray 9y ago
> clearly he had been involved personally in most of the things I was criticizing: code of poor quality with no validation of inputs, lots of partially finished modifications (see the lava flow anti-pattern), lack of unit tests, obvious differences between production and staging environments, developers releasing from their own machines rather than the CI server... things that, in my opinion, would be irresponsible to ignore.
Funny how people never seem to be as grateful as you'd think for this valuable service.
- iamcasen 9y agoRight? I would be so happy to hire someone smarter than me who can teach me how to be better. Sure if someone was telling me my code was shitty, but their solutions weren't any better or smarter, I would get pissed. I suppose some people aren't smart enough to know when they are wrong?
- marshray 9y agoSeems like 'smart' is unrelated to the ability to give or receive feedback, or maybe even inversely correlated. Another aspect of this: Say person B is smarter than person A, and A realizes this. Now person C, who is smarter than person B, joins the team. A can usually tell that C is smarter than B, but he can't realistically judge by how much because both B and C are playing above his level. A consequence of this that when C joins the team, the working relationship with B will usually be established without issues. But A is likely to feel his own status is being disrupted because his uncertain perception of the relationship between B and C is going to challenge the status quo he had worked out with B. When A observes spirited discussion between B and C, A may have trouble recognizing healthy debate on the merits and may erroneously perceive it as some type of interpersonal conflict.