7 ms·

The main thing I want to hide in minimized comments are "+1 fix this plz!" comments on bugs, comments that add nothing above and beyond a thumbs-up reaction. T

The main thing I want to hide in minimized comments are "+1 fix this plz!" comments on bugs, comments that add nothing above and beyond a thumbs-up reaction. The "reasons" Github offers for minimizing comments are: Spam, Abuse, Off Topic, Outdated, and Resolved. "+1" isn't exactly any of those. (I guess they're kinda "Spam" but they're not unsolicited commercial messages.)

ocdtrekkie 9y ago
Maybe the missing feature here is that GitHub should "just" automatically minimize +1 comments. Or even better, delete them without sending a notification to maintainers/watchers, and automagically have the user who posted it add a thumbs up to the original issue. (Personally, I would consider them spam.)
- reificator 9y ago
  I think they were valuable back when you couldn't react to a specific comment. I also think they're still valuable when you have Github and another VCS host, where one mirrors the other automatically.
- joshfriend 9y ago
  > automagically have the user who posted it add a thumbs up to the original issue. I was astonished that they didn't do this when they introduced the emoji reactions feature.
  - michaelmior 9y ago
    Part of the problem is deciding what the +1 should be attached to. Some people comment +1 just because they want to see a PR merged. Some +1s are intended to be associated with a specific comment.
    - Cthulhu_ 9y ago
      But there's other systems for that; what you're describing are 'bumps' that have been in forums and such for forever now, and I'm sure that e.g. an upvote system (or sort by +1 reactions) would replace that system. I think it could be done on a per repository basis, like, basic behaviour rules just like at forums and other such communities. It's then up to the maintainer / moderators / whatever to allow or disallow +1-style comments, and what the 'punishment' would be. They could then also tweak a setting that auto hides comments if they're shorter than X characters.
      - tuespetre 9y ago
        You can sort by reactions on the issues list, if that’s what you meant.
- craftyguy 9y ago
  > Or even better Well then the user would learn nothing. A better solution would be to notify them that this is wrong, delete their comment, and then prevent them from commenting on github.com for a period of time (1 hour? or more?)
Mashimo 9y ago
They don't contribute to the topic, I would mark them as Off Topic.
- raarts 9y ago
  Why not create a category 'redundant'?
falanjito 9y ago
If you see the users of your library as SPAM you might as well kill yourself.
- daeken 9y ago
  'dang: Suggestion in light of this comment: Maybe users should be autobanned if they have N flags within M minutes of account creation. This is an obvious troll account, but as of now it'll take way too long (IMO) for them to be banned. Something to think about!
  - sctb 9y ago
    Thanks for the suggestion, we've added it to our list! Meanwhile we've banned the account, of course.
jerrac 9y ago
Is there a way for users to easily demonstrate the need/desire for an issue to be fixed to developers? Do developers actually pay attention to how many reactions there are on issues? If you don't have anything more to add to the discussion, but it seems like the issue is not being considered, a "+1" comment seems like the most effective way to communicate the need to the devs. Ideally a thumbs up reaction would do the same thing, but does it? Do devs use the sort by "reaction" feature in real life? I have not yet had the chance to be on the other side. I'm pretty sure I'd check that list occasionally, but I bet I'd forget a lot of the time. Especially if I had a busy project. Sorting by "most recent" or "number of" comments would be more likely. And that would make a "+1" comment more effective.

ocdtrekkie 9y ago

Maybe the missing feature here is that GitHub should "just" automatically minimize +1 comments. Or even better, delete them without sending a notification to maintainers/watchers, and automagically have the user who posted it add a thumbs up to the original issue. (Personally, I would consider them spam.)

reificator 9y ago
I think they were valuable back when you couldn't react to a specific comment. I also think they're still valuable when you have Github and another VCS host, where one mirrors the other automatically.
joshfriend 9y ago
> automagically have the user who posted it add a thumbs up to the original issue. I was astonished that they didn't do this when they introduced the emoji reactions feature.
- michaelmior 9y ago
  Part of the problem is deciding what the +1 should be attached to. Some people comment +1 just because they want to see a PR merged. Some +1s are intended to be associated with a specific comment.
  - Cthulhu_ 9y ago
    But there's other systems for that; what you're describing are 'bumps' that have been in forums and such for forever now, and I'm sure that e.g. an upvote system (or sort by +1 reactions) would replace that system. I think it could be done on a per repository basis, like, basic behaviour rules just like at forums and other such communities. It's then up to the maintainer / moderators / whatever to allow or disallow +1-style comments, and what the 'punishment' would be. They could then also tweak a setting that auto hides comments if they're shorter than X characters.
    - tuespetre 9y ago
      You can sort by reactions on the issues list, if that’s what you meant.
craftyguy 9y ago
> Or even better Well then the user would learn nothing. A better solution would be to notify them that this is wrong, delete their comment, and then prevent them from commenting on github.com for a period of time (1 hour? or more?)

Mashimo 9y ago

They don't contribute to the topic, I would mark them as Off Topic.

raarts 9y ago
Why not create a category 'redundant'?

falanjito 9y ago

If you see the users of your library as SPAM you might as well kill yourself.

daeken 9y ago
'dang: Suggestion in light of this comment: Maybe users should be autobanned if they have N flags within M minutes of account creation. This is an obvious troll account, but as of now it'll take way too long (IMO) for them to be banned. Something to think about!
- sctb 9y ago
  Thanks for the suggestion, we've added it to our list! Meanwhile we've banned the account, of course.

jerrac 9y ago

Is there a way for users to easily demonstrate the need/desire for an issue to be fixed to developers? Do developers actually pay attention to how many reactions there are on issues? If you don't have anything more to add to the discussion, but it seems like the issue is not being considered, a "+1" comment seems like the most effective way to communicate the need to the devs. Ideally a thumbs up reaction would do the same thing, but does it? Do devs use the sort by "reaction" feature in real life? I have not yet had the chance to be on the other side. I'm pretty sure I'd check that list occasionally, but I bet I'd forget a lot of the time. Especially if I had a busy project. Sorting by "most recent" or "number of" comments would be more likely. And that would make a "+1" comment more effective.