4 ms·

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

by maxnoe 9y ago

rurban 9y ago
I see this new feature as a bug. If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.
- chr1 9y ago
  Sometimes people use compare view and accidentally create pull requests without description from branches on which they do not have any commits. On popular projects this happens often enough to become annoyance for maintainers. I don't see any case when opening a pull request from someone else's branch and without a description could be done intentionally.
- handbanana 9y ago
  If I understand the changes correctly, I agree.
- TheDong 9y ago
  If you wish to create a pull request, you can always push the content you wish to PR to your fork of the repo and create one. It does add an extra step if you wish to PR someone else's code (you now have to fetch it from their remote, push it to yours, and then make the PR vs directly cross-repo PR between two repos you don't own). It's not a heavy extra step though and I don't see this as removing the ability for any number of small PRs.
pietroalbini 9y ago
As far as I understood this means you can't create pull requests of branches you don't have push access to (for example other people's forks) unless you're a project collaborator. It shouldn't affect your own branches.
claudiulodro 9y ago
I believe it's an attempt to stop PRs like this: https://github.com/woocommerce/woocommerce/pull/19545 https://github.com/woocommerce/woocommerce/pull/19545 We get at least one of those a day and they are user error, spam or something. Definitely a useful feature for popular open source projects.
- justinclift 9y ago
  That one (in your URL) looks like the result of a PR between mismatched branches. eg instead of being the intended/correct source and destination branch, it's between two branches fairly far apart. Thus a shed load of commits to try and resolve the difference. Hopefully this new behaviour does fix the problem. On the other hand, I have a feeling it might alienate potential contributors who just aren't that familiar with git yet and could instead do with some guidance (ie how to use the correct branch to base changes on). I guess we get to find out. :)

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

by maxnoe 9y ago

Can someone explain the Pull Request restrictions? What does: "the changes are not explained in the commit body" actually mean? Is this opt in?

rurban 9y ago

I see this new feature as a bug. If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.

chr1 9y ago
Sometimes people use compare view and accidentally create pull requests without description from branches on which they do not have any commits. On popular projects this happens often enough to become annoyance for maintainers. I don't see any case when opening a pull request from someone else's branch and without a description could be done intentionally.
handbanana 9y ago
If I understand the changes correctly, I agree.
TheDong 9y ago
If you wish to create a pull request, you can always push the content you wish to PR to your fork of the repo and create one. It does add an extra step if you wish to PR someone else's code (you now have to fetch it from their remote, push it to yours, and then make the PR vs directly cross-repo PR between two repos you don't own). It's not a heavy extra step though and I don't see this as removing the ability for any number of small PRs.

pietroalbini 9y ago

As far as I understood this means you can't create pull requests of branches you don't have push access to (for example other people's forks) unless you're a project collaborator. It shouldn't affect your own branches.

claudiulodro 9y ago

I believe it's an attempt to stop PRs like this: https://github.com/woocommerce/woocommerce/pull/19545 https://github.com/woocommerce/woocommerce/pull/19545 We get at least one of those a day and they are user error, spam or something. Definitely a useful feature for popular open source projects.

justinclift 9y ago
That one (in your URL) looks like the result of a PR between mismatched branches. eg instead of being the intended/correct source and destination branch, it's between two branches fairly far apart. Thus a shed load of commits to try and resolve the difference. Hopefully this new behaviour does fix the problem. On the other hand, I have a feeling it might alienate potential contributors who just aren't that familiar with git yet and could instead do with some guidance (ie how to use the correct branch to base changes on). I guess we get to find out. :)