6 ms·
one suggestion I have, since I noticed that your build script to build from source seems to check out master, is to pin to a specific version of v8 - that makes
by jerrysievert 9y ago
one suggestion I have, since I noticed that your build script to build from source seems to check out master, is to pin to a specific version of v8 - that makes it a bit easier than trying to keep up with a moving target :)
- dectroo 9y agoAh yah, Thank you. Even internally I use brew'd, apt-get'd and nuget'd version for build. I want that my plugin compile faster ;) The v8 build script is kept for advanced user and potential contributors ;)
- jerrysievert 9y agoyou should probably check the versions - if memory serves, the brew and nuget versions of v8 are pre 6.4.388.14 (which is I believe the version that fixes the spectre/meltdown issues), and apt-get usually installs 3.14, which is way way way old (5 years?) just checked, nuget is 6.4.388.11, brew is 5.1.281.47 - do your users a favor, and get this updated asap. plv8 uses 6.4.388.40, which is fairly safe, but requires a build from source. FYI, my email is in my profile, if you want to move this off of hn.
- dectroo 9y agoYou're right brew check out version 5.1. but in apt-get I use another ppa which brings version 5.9 Where can I find your email!?
- jerrysievert 9y agojerry (at) legitimatesounding.com