20 ms·
I don't think it's a great idea to name an unofficial project "GoPro-Py", GoPro is a trademark. Also, the code mixes notation. Most Python code use snake_case
by sorenjan 9y ago
I don't think it's a great idea to name an unofficial project "GoPro-Py", GoPro is a trademark.
Also, the code mixes notation. Most Python code use snake_case because it's encouraged in PEP8, this code use both snake_case and camelCase (take_photo(X), getStatusRaw()).
- konraditurbe 9y agoYes, I did mix cases, take_photo() and shoot_video() are quick access commands that's why they're in different case. GitHub states it's an unofficial API in the title as well.
- dna_polymerase 9y ago> GitHub states it's an unofficial API in the title as well. The ReadMe headline only says GoPro, nothing about unofficial. It looks like it is official, especially with the product pics in the readme. I wouldn't be surprised if GoPro will ask you to remove the repo, or rename it.
- konraditurbe 9y agoFirst line after title: Unofficial GoPro API Library for Python - connect to GoPro cameras via WiFi. If it was official, the repo should be under @gopro not my username. I have worked with GoPro cameras and published a lot on my GitHub and I had no problems with them.
- guitarbill 9y agoThe whole PEP8 thing sounds pedantic, but will help people use the library in the long run. Using different cases for certain methods isn't really a convention in Python, and tripped me up a bit, too.
- IAmEveryone 9y agoThere's twitter-python, pytesla, DisneyDisp, github.com/scottjbarr/nasdaq, pyfacebook, etc etc. It seems to be accepted practice to use trademarks in names for projects connecting or related to them. But a statement emphasising the unoffical nature would probably be a good idea just in case.