3 ms·
> If this was a code review, the end of the month code in this example should get flagged for its complexity, when it can be replaced with the single conditiona
by dvt 9y ago
> If this was a code review, the end of the month code in this example should get flagged for its complexity, when it can be replaced with the single conditional "if tomorrow.day == 1".
But it's not a code review. It's a frivolous and simple example to show the underlying impact of not understanding the context of a hypothetical feature request. I have a feeling that in typical engineer fashion, you're missing the forest for the trees. Trust me, I've been there :)
- someguydave 9y agoHow does the computer know that today is the first day of the month without already having a complete calender implentation?
- thwarted 9y agoIt's a frivolous and simple example to show the underlying impact of not understanding the context of a hypothetical feature request. Yes, it is a contrived example, that's my point. But it's not the programmer that didn't understand the feature request, it's the entire organization. A questionable decision earlier made by the Account Manager led to an overly complex, questionable implementation that will lead to more code and more bugs. Trust me, I've been there.