4 ms·
You should really look at the sample hooks. Instead of of recursively grep'ing the entire source tree, you can look at just what is being committed. For example
by js2 16y ago
You should really look at the sample hooks. Instead of of recursively grep'ing the entire source tree, you can look at just what is being committed. For example, for pre-commit you can do this instead:
#!/bin/sh
if git rev-parse --verify HEAD >/dev/null 2>&1
then
against=HEAD
else
# Initial commit: diff against an empty tree object
against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
fi
if git diff --cached --diff-filter=AM $against -U0 |
grep "require 'ruby-debug'; debugger" > /dev/null
then
echo "Error: You twit, you've left a debugger in!"
exit 1
fi
- glenngillen 16y agoGood point. It did start as something akin to that and I forgot that over time I've adapted the approach to catch things left in by other developers (and already committed to the codebase). Given the catching the debug statement is limited to my very specific usage, your suggestion would be more suitable.
- js2 16y agoYou also don't need to look at every commit with git log. Just look at the commits you haven't pushed presumably with: git log -i -E --grep='[[:<:]]wip[[:>:]]' @{upstream}.. You'll notice I also grep'ed for "wip" (as a stand-alone word) with log itself, though this matches anywhere in the commit message, not just the subject. Add --author to this if you like, and maybe --oneline | grep '...' if you further want to grep to just the subject. The git man pages are a decent reference for this kind of stuff.
- js2 16y agoAnd checking for master should be done like this: test "master" == "$(git rev-parse --abbrev-ref HEAD)" And probably not by grep'ing the output of symbolic-ref. Again, for stuff like this, take a look at git itself. Some fairly major parts of it (such as rebase) are still shell scripts, and the stuff that's once was shell scripts can be found in git.git/contrib/examples