4 ms·
To my eye, the start of the code block is signified by the indentation, i.e.: stuffstuffstuff.... stuffstuffstuff... So I read C and Python (and Lis
by lisper 9y ago
To my eye, the start of the code block is signified by the indentation, i.e.:
stuffstuffstuff....
stuffstuffstuff...
So I read C and Python (and Lisp) code the same way. A naked open brace looks jarring and ugly to me. It also increases the separation of other related parts of the code, i.e.
if (...) {
while(...) {
do(...) {
vs
if (...)
{
while(...) {
{
do(...) {
The latter seems unnecessarily wasteful to me.
- Merad 9y agoK&R isn't that terrible when code is neat and clean, but it starts to have trouble IMO particularly when declarations or conditions wrap to multiple lines. Compare the following examples... I personally have to stop and read the code to find the blocks with K&R braces, vs being able to see them at a glance with Allman. void MyLongMethodName(SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3) { if (longContrivedVariableName1 == longContrivedVariableName2 && longContrivedVariableName1 != longContrivedVariableName3) { // do stuff } } void MyLongMethodName(SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3) { if (longContrivedVariableName1 == longContrivedVariableName2 && longContrivedVariableName1 != longContrivedVariableName3) { // do stuff } }
- lisper 9y agoEmacs autoindent to the rescue: void MyLongMethodName(SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3) { if (longContrivedVariableName1 == longContrivedVariableName2 && longContrivedVariableName1 != longContrivedVariableName3) { // do stuff } }
- Rusky 9y agoI treat the parentheses the same way I treat the braces: void MyLongMethodName( SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3 ) { if ( longContrivedVariableName1 == longContrivedVariableName2 && longContrivedVariableName1 != longContrivedVariableName3 ) { // do stuff } } I also make liberal use of temporary variables: void MyLongMethodName( SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3 ) { auto condition1 = longContrivedVariableName1 == longContrivedVariableName2; auto condition2 = longContrivedVariableName1 != longContrivedVariableName3; if (condition1 && condition2) { // do stuff } } Vertical space is allocated to the actual parameters and conditions, and the extra syntax-only lines exist only to separate chunks. This works well with "paragraphs": void MyLongMethodName( SomeLongParamType param1, SomeOtherLongParamType param2, YetAnotherLongParamType param3 ) { auto condition1 = longContrivedVariableName1 == longContrivedVariableName2; auto condition2 = longContrivedVariableName1 != longContrivedVariableName3; if (condition1 && condition2) { // do stuff } auto someData = buildSomeData(); doSomethingWith(someData); while (someCondition) { // loop } finishUp(); return someData; }