2 ms·
Here is a small issue: https://github.com/claudiodangelis/qr-filetransfer/blob/master/main.go#L65 https://github.com/claudiodangelis/qr-filetransfer/blob/mast..
by andmarios 9y ago
Here is a small issue:
https://github.com/claudiodangelis/qr-filetransfer/blob/master/main.go#L65 https://github.com/claudiodangelis/qr-filetransfer/blob/mast...
I don't know if it is the barcode scanner app (I use the one from zxing, a very popular choice), or the Android implementation (LG, Android 7), but here is a description of what happens:
As soon as I scan the barcode, it is copied to the clipboard. Then something goes to check if the URL is working (the barcode app? android clipboard? not sure). Since you exit after the first request, my browser never gets the chance to download the file.
If I remove the os.Exit(), I get it working (and then terminate qr-filetransfer via ctrl+c).
Anyhow, very nice work. Kudos!
- daw___ 9y agoHi, this has been already reported, many thanks for the headsup. The reason of that os.Exit(0) is to let the user not to care about quitting the tool after the transfer has been completed. There might be pending pull requests that fix this problem, I'm going to review later today. Users response to this tool is really overwhelming, lots of interesting ideas and solutions have been already provided in the last 24 hours!