3 ms·
Browsing through the source, this strikes me as very over-engineered to just hit a few APIs, parse the responses and print text to the command line.
by spyspy 9y ago
Browsing through the source, this strikes me as very over-engineered to just hit a few APIs, parse the responses and print text to the command line.
- Rican7 9y agoHa, that's such a classic HN comment. I appreciate you taking the time to look at the source. I used this, like I do most of my side projects, as an opportunity to learn a few things. I wanted a generic abstraction so that multiple sources could be used. Originally I didn't want or think of the need to support multiple sources, but it quickly became apparent how necessary that was when looking at the quality of free vs paid vs personal-key-required sources. In any case, thanks for checking it out!
- spyspy 9y agoSorry, not trying to be a put down. Just a lot of code smells that I see reviewing other people's go at work. Things like the abundance of interfaces, defining your own IO and error handling, use of reflection, and using third party libraries for simple tasks. I'll definitely say the code is at least clean and well documented, so kudos there.
- rhencke 9y agoI actually thought the PanicWriter was very clever. It's a clean solution to a very commonly ignored error return value - operations on stdout/stderr.
- Rican7 9y agoThanks!
- icholy 9y agoNo kidding, it just kept going and going.