10 ms·

I hate it that Gitlab is focusing too much on all these project-management features, while neglecting the basic code review features such as commenting on a blo

I hate it that Gitlab is focusing too much on all these project-management features, while neglecting the basic code review features such as commenting on a block of code, or making a review session instead of creating individual comments, or the ability to blame previous revisions of a file

0x0 9y ago
At least you can blame previous revisions of a file? Using an URL like gitlab.com/username/project/blame/COMMITHASH_OR_TAG/path/to/file
- chinhodado 9y ago
  You can, but you need to copy-paste the hash to the URL manually, which is not exactly good UX.
  - 0x0 9y ago
    No you don't? If you click on a particular commit, you can click "View file @ HASH" and from the click the Blame button?
    - chinhodado 9y ago
      When you click on a particular commit, you see all the files affected by that commit, which can be in the dozens. Now you have to search for the file you're interested in again, click on View file at..., then in there search again for the line you're interested in, click on it then go back to the top of the page and click on Blame (or click Blame first and search for your line later, same thing). How many steps was that?
andrewstuart2 9y ago
It's open source. I'm sure they wouldn't turn down a PR if you submitted one. I've poked around the codebase a few times; it's not too hard to contribute, despite my lack of experience with ruby.
- gtirloni 9y ago
  It's open core, not open source. I'm pretty sure they would have a lot of incentives to turn it down.
  - jobvandervoort 9y ago
    We don't have a lot of incentives to turn down contributions. Quite the opposite. We not only encourage this, we actively help people contributing to GitLab. It's humbling to be a steward to an open source project and something we don't take lightly [0]. And to be blunt, for an organisation as ours, with very ambitious goals, and highly demanding users, having someone else than us contribute something that makes the product better is the best possible deal we could do. We can compensate for the 'lost' value in our enterprise product by spending that time on other things that are maybe more interesting for our paying customers. [0]: https://about.gitlab.com/stewardship/ https://about.gitlab.com/stewardship/
    - gtirloni 9y ago
      That's reassuring, thanks for replying. I was commenting from a general perspective on open core licensing but I understand not all companies are created equal.
- victorwu 9y ago
  Product manager at GitLab here. We welcome contributions! See https://about.gitlab.com/contributing/ https://about.gitlab.com/contributing/ and https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU...
paxys 9y ago
This release is mainly for improved CI/CD and Kubernetes support. How is that related to project management?
victorwu 9y ago
These are exactly the type of features we are focused on this year. Commenting on a block of code: https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 Making a review session: https://gitlab.com/groups/gitlab-org/-/epics/23 https://gitlab.com/groups/gitlab-org/-/epics/23 And here’s a greater overview: https://about.gitlab.com/direction/#merge-requests-approvals-and-code-review https://about.gitlab.com/direction/#merge-requests-approvals...
- tandr 9y ago
  Now if you guys would get to... 1. ... allow to specify somehow a size of TAB symbol per user or per project (or per review), so we might be able to review Go code normally, without plugins or custom CSS for the browser (8 char default is making code a lot harder to review,especially side-by-side). Yes, there were at least 3 different tickets opened about it the last time I have checked. No, the answer "we going to have .editorconfig support one day" or "good suggestion, maybe one day" are not making it after 2+ years, sorry) 2. ... filename not being hidden by icons would be so awesome in knowing which Java file with 200 char filepath I am trying to review without copying filename to clipboard, and looking at it in VS Code. Wrapping icons is ok, I don't care where is "copy file name" button is located that much. 3. ... have some file patterns rules about what files I would like to have collapsed by default. And while we are at it, add what files to display with ignore-space diff, and which do not, so I will not start every review with the same magic mouse triple click with full reloads of 15 files in between. Sorry for the rant, code reviews is one of my main responsibilities and this just drives me nuts every day.
victorwu 9y ago
Here's an example of a blame on a previous commit of a file. https://gitlab.com/gitlab-org/gitlab-ce/blame/57ce7c655cc58ee793cf6514fae590fa53850884/.gitlab-ci.yml https://gitlab.com/gitlab-org/gitlab-ce/blame/57ce7c655cc58e... Did you have some particular feature request beyond this view?
- chinhodado 9y ago
  The use case is to be able to repeatedly blame on the previous revision of the change that was made to a line. This is especially useful when you're dealing with diffs resulted from code formatting, whitespace changes, etc. in a file and you want to see what is the "original" commit that the change was made. This has been available on GitHub for a while now (see https://help.github.com/articles/tracing-changes-in-a-file/ https://help.github.com/articles/tracing-changes-in-a-file/)
  - victorwu 9y ago
    Thank you for the explanation. I've created an issue. Feel free to continue the discussion there. https://gitlab.com/gitlab-org/gitlab-ce/issues/44553 https://gitlab.com/gitlab-org/gitlab-ce/issues/44553
    - tmuir 9y ago
      Does this mean that gitlab doesn't generally employ people to simply learn their competitors products, to keep informed of their offerings?
      - yashap 9y ago
        This is a highly unfair criticism, you’re never going to have total feature parity with your competitors, nor is that even a good thing to strive for.
        deleted 9y ago
        [deleted]
dogweather 9y ago
Or basic modern web UX. Like using a wide screen effectively.
- svesselov 9y ago
  Under your profile settings/preferences, you have the ability to set your layout to 'fluid' This will allow the application to take up 100% of the width of the screen. If you have more specific UX issues you think we should address, I'd love to hear them!

0x0 9y ago

At least you can blame previous revisions of a file? Using an URL like gitlab.com/username/project/blame/COMMITHASH_OR_TAG/path/to/file

chinhodado 9y ago
You can, but you need to copy-paste the hash to the URL manually, which is not exactly good UX.
- 0x0 9y ago
  No you don't? If you click on a particular commit, you can click "View file @ HASH" and from the click the Blame button?
  - chinhodado 9y ago
    When you click on a particular commit, you see all the files affected by that commit, which can be in the dozens. Now you have to search for the file you're interested in again, click on View file at..., then in there search again for the line you're interested in, click on it then go back to the top of the page and click on Blame (or click Blame first and search for your line later, same thing). How many steps was that?

andrewstuart2 9y ago

It's open source. I'm sure they wouldn't turn down a PR if you submitted one. I've poked around the codebase a few times; it's not too hard to contribute, despite my lack of experience with ruby.

gtirloni 9y ago
It's open core, not open source. I'm pretty sure they would have a lot of incentives to turn it down.
- jobvandervoort 9y ago
  We don't have a lot of incentives to turn down contributions. Quite the opposite. We not only encourage this, we actively help people contributing to GitLab. It's humbling to be a steward to an open source project and something we don't take lightly [0]. And to be blunt, for an organisation as ours, with very ambitious goals, and highly demanding users, having someone else than us contribute something that makes the product better is the best possible deal we could do. We can compensate for the 'lost' value in our enterprise product by spending that time on other things that are maybe more interesting for our paying customers. [0]: https://about.gitlab.com/stewardship/ https://about.gitlab.com/stewardship/
  - gtirloni 9y ago
    That's reassuring, thanks for replying. I was commenting from a general perspective on open core licensing but I understand not all companies are created equal.
victorwu 9y ago
Product manager at GitLab here. We welcome contributions! See https://about.gitlab.com/contributing/ https://about.gitlab.com/contributing/ and https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU...

paxys 9y ago

This release is mainly for improved CI/CD and Kubernetes support. How is that related to project management?

victorwu 9y ago

These are exactly the type of features we are focused on this year. Commenting on a block of code: https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 Making a review session: https://gitlab.com/groups/gitlab-org/-/epics/23 https://gitlab.com/groups/gitlab-org/-/epics/23 And here’s a greater overview: https://about.gitlab.com/direction/#merge-requests-approvals-and-code-review https://about.gitlab.com/direction/#merge-requests-approvals...

tandr 9y ago
Now if you guys would get to... 1. ... allow to specify somehow a size of TAB symbol per user or per project (or per review), so we might be able to review Go code normally, without plugins or custom CSS for the browser (8 char default is making code a lot harder to review,especially side-by-side). Yes, there were at least 3 different tickets opened about it the last time I have checked. No, the answer "we going to have .editorconfig support one day" or "good suggestion, maybe one day" are not making it after 2+ years, sorry) 2. ... filename not being hidden by icons would be so awesome in knowing which Java file with 200 char filepath I am trying to review without copying filename to clipboard, and looking at it in VS Code. Wrapping icons is ok, I don't care where is "copy file name" button is located that much. 3. ... have some file patterns rules about what files I would like to have collapsed by default. And while we are at it, add what files to display with ignore-space diff, and which do not, so I will not start every review with the same magic mouse triple click with full reloads of 15 files in between. Sorry for the rant, code reviews is one of my main responsibilities and this just drives me nuts every day.

victorwu 9y ago

Here's an example of a blame on a previous commit of a file. https://gitlab.com/gitlab-org/gitlab-ce/blame/57ce7c655cc58ee793cf6514fae590fa53850884/.gitlab-ci.yml https://gitlab.com/gitlab-org/gitlab-ce/blame/57ce7c655cc58e... Did you have some particular feature request beyond this view?

chinhodado 9y ago
The use case is to be able to repeatedly blame on the previous revision of the change that was made to a line. This is especially useful when you're dealing with diffs resulted from code formatting, whitespace changes, etc. in a file and you want to see what is the "original" commit that the change was made. This has been available on GitHub for a while now (see https://help.github.com/articles/tracing-changes-in-a-file/ https://help.github.com/articles/tracing-changes-in-a-file/)
- victorwu 9y ago
  Thank you for the explanation. I've created an issue. Feel free to continue the discussion there. https://gitlab.com/gitlab-org/gitlab-ce/issues/44553 https://gitlab.com/gitlab-org/gitlab-ce/issues/44553
  - tmuir 9y ago
    Does this mean that gitlab doesn't generally employ people to simply learn their competitors products, to keep informed of their offerings?
    - yashap 9y ago
      This is a highly unfair criticism, you’re never going to have total feature parity with your competitors, nor is that even a good thing to strive for.
      - deleted 9y ago
        [deleted]

dogweather 9y ago

Or basic modern web UX. Like using a wide screen effectively.

svesselov 9y ago
Under your profile settings/preferences, you have the ability to set your layout to 'fluid' This will allow the application to take up 100% of the width of the screen. If you have more specific UX issues you think we should address, I'd love to hear them!