3 ms·
I would reject that PR. Something like that change should have a message explaining why that change is proposed. Unfortunate that the blogpost itself can't be
by shady-lady 9y ago
I would reject that PR.
Something like that change should have a message explaining why that change is proposed.
Unfortunate that the blogpost itself can't be forked :p
- jeffbarr 9y agoI wrote it -- do I need to make a fix??
- shady-lady 9y agowell, it depends on what type of comments you guys find acceptable & would want to see when you're deciding whether to merge the changes in. imagine down the line somebody submitting changes & the message isn't the reason why those changes are there[0] but instead a copy paste of the changes[1] [0] e.g. "remove fuzzy language"/"update intro to more accurately reflect addition of new services" [1] not denying that sometimes this makes more sense.