6 ms·

The fix isn't the hard part. It's the deployment and validation that can take time. Pretty impressive.

by compiler-guy 9y ago

sundvor 9y ago
Yep, clearly shows the value of a properly configured CI/CD pipeline.
- ransom1538 9y ago
  Yeah here it is: git pull; sh tests; rsync /prod/ all@prod:/var/www/ ^ That is copyrighted by the way. Ill take a consultant fee. I know - I know it should be thousands of lines of puppet, jenkins, hooks, Kubernetes, Salt, and 2 million lines of python and ELM all piped through Docker containers -- I am NOT an animal.
  - xevb3k 9y ago
    Enterprise edition with test validiation and continuous deployment: while true; do git pull; sh tests && rsync /prod/ all@prod:/var/www/;done
    - hedora 9y ago
      You forgot to rewrite the logic in xml, and then fetch it over the internet from unknown third parties by tunneling it through json, then http. Bonus points if the the whole thing is deployed via docker hub.
  - pronoiac 9y ago
    !!! those ... those semicolons should be &&
    - hedora 9y ago
      You need to invoke the script via ‘sh -ex’ for proper exception handling + debuggability. Also, mktemp and shell exit traps are your friends.
  - davedx 9y ago
    Git pull - you have a staging server!?
  - paulddraper 9y ago
    Except that this is Facebook, so `sh tests` is going to take 900 cpu-hours
user5994461 9y ago
The deployment and the validation should be trivial if the fix is trivial. The difficult part is having someone who reads the report and escalates it, preferably in a timely manner.
- compiler-guy 9y ago
  The world is littered with the smoking, segfaulted, hulks of programs that were quickly deployed after an obvious fix.
  - deleted 9y ago
    [deleted]
- IncRnd 9y ago
  > The deployment and the validation should be trivial if the fix is trivial. Trivial. That's what Oculus said.
bobbyi_settv 9y ago
I'd more impressed in some other context since a willingness to skimp on validation and "red tape" is how a bug like this ends up in production in the first place.
Pxtl 9y ago
What validation? I'd assume for this one they'd take the "move fast and break things" approach.

The fix isn't the hard part. It's the deployment and validation that can take time. Pretty impressive.

sundvor 9y ago

Yep, clearly shows the value of a properly configured CI/CD pipeline.

ransom1538 9y ago
Yeah here it is: git pull; sh tests; rsync /prod/ all@prod:/var/www/ ^ That is copyrighted by the way. Ill take a consultant fee. I know - I know it should be thousands of lines of puppet, jenkins, hooks, Kubernetes, Salt, and 2 million lines of python and ELM all piped through Docker containers -- I am NOT an animal.
- xevb3k 9y ago
  Enterprise edition with test validiation and continuous deployment: while true; do git pull; sh tests && rsync /prod/ all@prod:/var/www/;done
  - hedora 9y ago
    You forgot to rewrite the logic in xml, and then fetch it over the internet from unknown third parties by tunneling it through json, then http. Bonus points if the the whole thing is deployed via docker hub.
- pronoiac 9y ago
  !!! those ... those semicolons should be &&
  - hedora 9y ago
    You need to invoke the script via ‘sh -ex’ for proper exception handling + debuggability. Also, mktemp and shell exit traps are your friends.
- davedx 9y ago
  Git pull - you have a staging server!?
- paulddraper 9y ago
  Except that this is Facebook, so `sh tests` is going to take 900 cpu-hours

user5994461 9y ago

The deployment and the validation should be trivial if the fix is trivial. The difficult part is having someone who reads the report and escalates it, preferably in a timely manner.

compiler-guy 9y ago
The world is littered with the smoking, segfaulted, hulks of programs that were quickly deployed after an obvious fix.
- deleted 9y ago
  [deleted]
IncRnd 9y ago
> The deployment and the validation should be trivial if the fix is trivial. Trivial. That's what Oculus said.

bobbyi_settv 9y ago

I'd more impressed in some other context since a willingness to skimp on validation and "red tape" is how a bug like this ends up in production in the first place.

Pxtl 9y ago

What validation? I'd assume for this one they'd take the "move fast and break things" approach.