4 ms·
Exactly. I mean look at his commits. Look at this file: https://github.com/ariya/phantomjs/blob/master/package.json https://github.com/ariya/phantomjs/blob/mast
by enitihas 9y ago
Exactly. I mean look at his commits. Look at this file: https://github.com/ariya/phantomjs/blob/master/package.json https://github.com/ariya/phantomjs/blob/master/package.json
(He created a commit only to add his how name as a contributor to package.json, which is the only name in package.json).
How did his changes even make it to the repo. There are commits adding and deleting whitespace with the disguised commit message of "Refactoring Code". I have no doubt on why ariya couldn't work with him.
- valleyer 9y agoSome of his commits surely don't even compile. This one takes the leading # characters off of preprocessor directives: https://github.com/ariya/phantomjs/commit/52e4849a36c68b15c6f08c6a8f74a9bd2f134722 https://github.com/ariya/phantomjs/commit/52e4849a36c68b15c6...
- ExactoKnight 9y agoThis is why every open source project needs a basic CircleCi.