5 ms·
Timeline of what lead to this, from what I could gather: • phantomjs is 7 years old, @pixiuPL has been contributing for about 2 months • @ariya didn't respond
by micimize 9y ago
Timeline of what lead to this, from what I could gather:
• phantomjs is 7 years old, @pixiuPL has been contributing for about 2 months
• @ariya didn't respond to his requests for owner level permissions
• @pixiuPL published an open letter to the main page of phantomjs.org https://github.com/ariya/phantomjs/issues/15345 https://github.com/ariya/phantomjs/issues/15345
• the stress leads @ariya to close the repo.
• @pixiuPL intends to continue development on a fork
This is a good reminder of why non-technical skills are so important in OS and in general.
- deleted 9y ago[deleted]
- rilut 9y agoI don't know man, but look at @pixiuPL's commits https://github.com/ariya/phantomjs/commits?author=pixiuPL https://github.com/ariya/phantomjs/commits?author=pixiuPL Especially his own commits (non-merge commits)
- bcherny 9y agoWhat about them?
- rilut 9y agoHe committed: - Removing one whitespace and adding an unnecessary file https://github.com/ariya/phantomjs/commit/98272b9752b2d505f7fcb9ae0d10651a808ea79f https://github.com/ariya/phantomjs/commit/98272b9752b2d505f7... - Conflicted files https://github.com/ariya/phantomjs/commit/63a69d9e2e9c31baab90b9711d88a836dce60e85 https://github.com/ariya/phantomjs/commit/63a69d9e2e9c31baab... - Personal build env https://github.com/ariya/phantomjs/commit/d57ff74f36c5b79d829e36ba7febaafcae3c9e3b https://github.com/ariya/phantomjs/commit/d57ff74f36c5b79d82... - Deleted the whole project while changing cloud provider https://github.com/ariya/phantomjs/commit/a242fb8d605d9aa4afe5bf8d1267c1ded15f157c https://github.com/ariya/phantomjs/commit/a242fb8d605d9aa4af... - then re-adding the whole project again https://github.com/ariya/phantomjs/commit/ddaaa09785d453e41554fd6133a2054c659a317f https://github.com/ariya/phantomjs/commit/ddaaa09785d453e415... and other weird/careless commits
- enitihas 9y agoNow, he shows up at number 4 in the Github contributor list (https://github.com/ariya/phantomjs/graphs/contributors https://github.com/ariya/phantomjs/graphs/contributors) with 179,603 lines added, not a single one of which seems to be a meaningful contribution by him. Are such incidences common in other open source software too, or does this one seem a rare case?
- micimize 9y agoI doubt it, but the line count / commit frequency heuristics really shouldn't be taken too seriously anyways
- ollysb 9y agoMake of it what you will but they appear to be a bunch of commits that amount to removing white space or adding/removing comments with messages like "Code refactoring". It looks a lot like someone trying to get their git blame count up by any means other than writing actual code.
- wojtek_83 9y agoI think its probably best for @pixiuPL to move on, have a look at how his actions/comments might be perceived by both the community and potential users, and treat this as a learning experience.
- ricardobeat 9y agoChanging default indentation from 2 spaces to tabs (without updating existing files?): https://github.com/ariya/phantomjs/commit/6485f5466110fc8d4b9b964cdca9953e2d635008 https://github.com/ariya/phantomjs/commit/6485f5466110fc8d4b... I couldn't find a single one containing any meaningful code changes. The closest one is a81a38f[1] which seems to introduce bugs - removing open file check, plus a hanging if clause. Sounds like it's either an elaborate prank, or the guy has no grounding on reality. [1] https://github.com/ariya/phantomjs/commit/a81a38ffabe2cea715ff1c6ab9425f006c3eb166 https://github.com/ariya/phantomjs/commit/a81a38ffabe2cea715...
- enitihas 9y agoExactly. I mean look at his commits. Look at this file: https://github.com/ariya/phantomjs/blob/master/package.json https://github.com/ariya/phantomjs/blob/master/package.json (He created a commit only to add his how name as a contributor to package.json, which is the only name in package.json). How did his changes even make it to the repo. There are commits adding and deleting whitespace with the disguised commit message of "Refactoring Code". I have no doubt on why ariya couldn't work with him.
- valleyer 9y agoSome of his commits surely don't even compile. This one takes the leading # characters off of preprocessor directives: https://github.com/ariya/phantomjs/commit/52e4849a36c68b15c6f08c6a8f74a9bd2f134722 https://github.com/ariya/phantomjs/commit/52e4849a36c68b15c6...
- ExactoKnight 9y agoThis is why every open source project needs a basic CircleCi.
- draw_down 9y agoI guess so. But it just seems like this person is done. People are allowed to be done. And really, communication skills on the part of community members should be emphasized as well. Edit: after reading some more of the reasoning and the discussions that led to this, I’m even less inclined to blame the maintainers for closing the project. People wanted more than it could give. If this other person really wants to take on that burden with a fork, by all means.
- watwut 9y agoWho is lacking non-technical skills in that scenario? I just don't see it.
- enitihas 9y agoI think looking at @pixiuPL's commits (https://github.com/ariya/phantomjs/commits?author=pixiuPL https://github.com/ariya/phantomjs/commits?author=pixiuPL) and his tall, non sensical claims makes it clear who lacks the basic human communication skills. Just have a look for yourself. Looking at some issues filed by him (https://github.com/composer/composer/issues/7016 https://github.com/composer/composer/issues/7016) makes the entire thing more clear.
- watwut 9y agoGotcha. Through, lack of communications skills and being either delusional or complete dick is not the same. Meaning there are people whose main problem is lack of communication skills and people whose problems run much deeper.