7 ms·

GitHub launches Pull Requests 2.0

204 points by kneath 16y ago

spooneybarger 16y ago
For me, github is git's killer application. I wouldn't be using git if I couldn't pair it with github.
- icey 16y ago
  I've gotten to the point that I will often choose a different library if the one I'm looking at isn't already on github because their interface is so nice for browsing code (not to mention finding useful forks).
  - jackowayed 16y ago
    Me too. I'll tolerate Google Code or whatever if I know the library is good, but if I'm just googling for stuff (well, duck duck going), I'm a lot more likely to say "eh, let's keep looking" if it's not on github.
  - po 16y ago
    I think this is because a project being on github is a huge signal of "I care about my project" which I want if I'm going to be leaning on it for my project. Like they say, you can always tell if a google code project is active if it says "we've moved to github..." Github just needs a "Google Groups" without the spam and they're set.
    - jnoller 16y ago
      Why is being on github a "huge signal" that they care? They're pushing code into the wild, giving it away for free and actively maintaining it - who cares where they host it if the code is good code? I'm getting really disturbed at this "if it's not on github it doesn't exist" meme. In the past it was "if it's not on sourceforge it doesn't exist" - what's next?
      - po 16y ago
        If the code is good code, then it's good code. You're right about that and I certainly don't go around thinking "If it's not on github, it's bad code." However, Github makes it very easy to inspect both the source code and the activity around the project. To me, the community that is developing around github is just as important as the code. I don't find that disturbing. I also like what Bitbucket is doing for what it's worth. Sourceforge, Google Code and a lot of other hosted solutions rely on advertising to make money. They're trying to sell clicks from a click-averse audience and it affects the service. Github is paid for by developers who want great tools. I won't hold it against a development group for picking something other than github but I think developers who want good tools will migrate there. I won't miss sourceforge. If it were merely a fashion trend, I would agree with you but I think github fundamentally changes the way you interact with code.
        Pistos2 16y ago
        Perhaps: "click-averse audience"?
        po 16y ago
        Yes, thank you. Although now I'm trying to figure out what click-adversity would be.
        bmelton 16y ago
        Finger cramps? Finger braces? Carpal tunnel?
        litewulf 16y ago
        Sidenote: Google Code doesn't seem to have ads.
        po 16y ago
        You're right, I stand corrected. I was thinking of Google Groups which is related but not the same thing.
- tzs 16y ago
  So what would you be using for source code control for your projects?
  - Zev 16y ago
    I'm in the same boat here. The only reason I use git is for github -- for work or collaborating with other people on something. And even then, unless I need branching, I'll still use Mercurial, through the hg-git plugin they provide[1]. Nothing against people who use git. If it works for you, use it. I don't like it because of its arcane incantations and tendency to let me destroy my work for the past few hours by using the wrong command. The features are great. But, not what I'm looking for in a DVCS. But, thats just me. 1. http://hg-git.github.com/ http://hg-git.github.com/
    - eru 16y ago
      > [...] and tendency to let me destroy my work for the past few hours by using the wrong command. I have the same misgivings about Mercurial. I guess it depends on what you are used to. Conceptually git and Mercurial are isomorphic. (See http://mercurial.selenic.com/wiki/GitConcepts http://mercurial.selenic.com/wiki/GitConcepts for an explanation.)
  - mitjak 16y ago
    CVS?
    - eru 16y ago
      Why?
  - spooneybarger 16y ago
    While none of the popular DVCS's perfectly match my normal workflow, bazaar is usually the closest. i see the power of git, but i don't really need its particular power bits and i find both mercurial and bazaar easier to work with.
    - 16y ago
Pistos2 16y ago
I love git, and I love github, but I honestly have not found any of the "mangle your repos through our website" features of github compelling. Perhaps it's because I don't have projects with hundreds of watchers, a couple dozen forks, and a pull request coming in every day. I just feel a lot more comfortable working with my repos on my own machine(s), with the CLI git commands. I can do what I want locally, and I have full control over any mangling or bungling, as well as whether or not said bungling gets pushed to what is often the official repo for the project (namely, the github repo of the project).
docgnome 16y ago
The only thing that could make github more awesome in my eyes would be if it was open source. While a lot of work has gone into gitorious, it seems like they are just playing catchup to some extent with github.
- steveklabnik 16y ago
  Much of GitHub already is.
- mrduncan 16y ago
  While the site isn't open-source, they have open-sourced a ton of code. Just to name a few: http://github.com/github http://github.com/github http://github.com/defunkt/resque http://github.com/defunkt/resque http://github.com/mojombo/jekyll http://github.com/mojombo/jekyll http://github.com/mojombo/god http://github.com/mojombo/god http://github.com/mojombo/bert http://github.com/mojombo/bert http://github.com/mojombo/grit http://github.com/mojombo/grit
  - jallmann 16y ago
    Yep, and they also put together awesome blog posts about how all those pieces tie together: http://news.ycombinator.com/item?id=895072 http://news.ycombinator.com/item?id=895072
- technoweenie 16y ago
  I guess I'm a bit of an OSS hippie, but I wish that too. But, having a business model means we can focus all of our time on this. We're able to do more for open source this way. Also: GitHub has released a bunch of open source (as others have added). One of the other things I like is that details of the architecture are discussed openly. When I joined GitHub a few months ago, I was shocked at how much I already knew about how things worked.
  - davidw 16y ago
    I've thought long and hard about open source and business for a while, and I think you're probably right. I think the best thing going right now for OS is a "pyramid", where all the infrastructure and supporting bits and pieces are open source, and the tip of the pyramid is the differentiator that makes the money. It may rankle some not to get access to that, but by being closed, you can make a lot of money to funnel back into the open source projects you use and support.
mronge 16y ago
Looks like I'm going to have to leave BitBucket. Features like these are just too compelling...
andymoe 16y ago
I really like GitHub and I know Fogbugz/Kiln is more expensive but the code review features and bug tracking stuff in FogBugz/Kiln is just so well done. The UI and interaction is so much more polished than anything else out there. Certainly more so than GitHub, Bitbucket and JIRA. If you are a business I think it's well worth the extra money. I even use it for my personal stuff.
- kneath 16y ago
  I'd love to see any screenshots or features that you find valuable. Feel free to throw anything at kyle@github.com that you want (rants appreciated)
- Mizza 16y ago
  What features in Kiln and Fogbugz? I use JIRA at work.. bleeeeeeeggggghhhh.
icco 16y ago
This is the final straw. I've been considering convincing my work to switch to git + GitHub, but I've just written up my proposal and I'm pitching it tomorrow, this is too awesome to pass up.
- eru 16y ago
  Please post your experiences. Some co-workers and me are considering a similar pitch.
newobj 16y ago
Github is just so awesome. They really nailed making code social. You really get the feeling of participating in a living, breathing thing with Github. It compels you to collaborate. It's frictionless. Every other hosted RCS just feels hopelessly static, a step above a download.com.

204 points by kneath 16y ago

spooneybarger 16y ago

For me, github is git's killer application. I wouldn't be using git if I couldn't pair it with github.

icey 16y ago
I've gotten to the point that I will often choose a different library if the one I'm looking at isn't already on github because their interface is so nice for browsing code (not to mention finding useful forks).
- jackowayed 16y ago
  Me too. I'll tolerate Google Code or whatever if I know the library is good, but if I'm just googling for stuff (well, duck duck going), I'm a lot more likely to say "eh, let's keep looking" if it's not on github.
- po 16y ago
  I think this is because a project being on github is a huge signal of "I care about my project" which I want if I'm going to be leaning on it for my project. Like they say, you can always tell if a google code project is active if it says "we've moved to github..." Github just needs a "Google Groups" without the spam and they're set.
  - jnoller 16y ago
    Why is being on github a "huge signal" that they care? They're pushing code into the wild, giving it away for free and actively maintaining it - who cares where they host it if the code is good code? I'm getting really disturbed at this "if it's not on github it doesn't exist" meme. In the past it was "if it's not on sourceforge it doesn't exist" - what's next?
    - po 16y ago
      If the code is good code, then it's good code. You're right about that and I certainly don't go around thinking "If it's not on github, it's bad code." However, Github makes it very easy to inspect both the source code and the activity around the project. To me, the community that is developing around github is just as important as the code. I don't find that disturbing. I also like what Bitbucket is doing for what it's worth. Sourceforge, Google Code and a lot of other hosted solutions rely on advertising to make money. They're trying to sell clicks from a click-averse audience and it affects the service. Github is paid for by developers who want great tools. I won't hold it against a development group for picking something other than github but I think developers who want good tools will migrate there. I won't miss sourceforge. If it were merely a fashion trend, I would agree with you but I think github fundamentally changes the way you interact with code.
      - Pistos2 16y ago
        Perhaps: "click-averse audience"?
        po 16y ago
        Yes, thank you. Although now I'm trying to figure out what click-adversity would be.
        bmelton 16y ago
        Finger cramps? Finger braces? Carpal tunnel?
      - litewulf 16y ago
        Sidenote: Google Code doesn't seem to have ads.
        po 16y ago
        You're right, I stand corrected. I was thinking of Google Groups which is related but not the same thing.
tzs 16y ago
So what would you be using for source code control for your projects?
- Zev 16y ago
  I'm in the same boat here. The only reason I use git is for github -- for work or collaborating with other people on something. And even then, unless I need branching, I'll still use Mercurial, through the hg-git plugin they provide[1]. Nothing against people who use git. If it works for you, use it. I don't like it because of its arcane incantations and tendency to let me destroy my work for the past few hours by using the wrong command. The features are great. But, not what I'm looking for in a DVCS. But, thats just me. 1. http://hg-git.github.com/ http://hg-git.github.com/
  - eru 16y ago
    > [...] and tendency to let me destroy my work for the past few hours by using the wrong command. I have the same misgivings about Mercurial. I guess it depends on what you are used to. Conceptually git and Mercurial are isomorphic. (See http://mercurial.selenic.com/wiki/GitConcepts http://mercurial.selenic.com/wiki/GitConcepts for an explanation.)
- mitjak 16y ago
  CVS?
  - eru 16y ago
    Why?
- spooneybarger 16y ago
  While none of the popular DVCS's perfectly match my normal workflow, bazaar is usually the closest. i see the power of git, but i don't really need its particular power bits and i find both mercurial and bazaar easier to work with.
  - 16y ago

Pistos2 16y ago

I love git, and I love github, but I honestly have not found any of the "mangle your repos through our website" features of github compelling. Perhaps it's because I don't have projects with hundreds of watchers, a couple dozen forks, and a pull request coming in every day. I just feel a lot more comfortable working with my repos on my own machine(s), with the CLI git commands. I can do what I want locally, and I have full control over any mangling or bungling, as well as whether or not said bungling gets pushed to what is often the official repo for the project (namely, the github repo of the project).

docgnome 16y ago

The only thing that could make github more awesome in my eyes would be if it was open source. While a lot of work has gone into gitorious, it seems like they are just playing catchup to some extent with github.

steveklabnik 16y ago
Much of GitHub already is.
mrduncan 16y ago
While the site isn't open-source, they have open-sourced a ton of code. Just to name a few: http://github.com/github http://github.com/github http://github.com/defunkt/resque http://github.com/defunkt/resque http://github.com/mojombo/jekyll http://github.com/mojombo/jekyll http://github.com/mojombo/god http://github.com/mojombo/god http://github.com/mojombo/bert http://github.com/mojombo/bert http://github.com/mojombo/grit http://github.com/mojombo/grit
- jallmann 16y ago
  Yep, and they also put together awesome blog posts about how all those pieces tie together: http://news.ycombinator.com/item?id=895072 http://news.ycombinator.com/item?id=895072
technoweenie 16y ago
I guess I'm a bit of an OSS hippie, but I wish that too. But, having a business model means we can focus all of our time on this. We're able to do more for open source this way. Also: GitHub has released a bunch of open source (as others have added). One of the other things I like is that details of the architecture are discussed openly. When I joined GitHub a few months ago, I was shocked at how much I already knew about how things worked.
- davidw 16y ago
  I've thought long and hard about open source and business for a while, and I think you're probably right. I think the best thing going right now for OS is a "pyramid", where all the infrastructure and supporting bits and pieces are open source, and the tip of the pyramid is the differentiator that makes the money. It may rankle some not to get access to that, but by being closed, you can make a lot of money to funnel back into the open source projects you use and support.

mronge 16y ago

Looks like I'm going to have to leave BitBucket. Features like these are just too compelling...

andymoe 16y ago

I really like GitHub and I know Fogbugz/Kiln is more expensive but the code review features and bug tracking stuff in FogBugz/Kiln is just so well done. The UI and interaction is so much more polished than anything else out there. Certainly more so than GitHub, Bitbucket and JIRA. If you are a business I think it's well worth the extra money. I even use it for my personal stuff.

kneath 16y ago
I'd love to see any screenshots or features that you find valuable. Feel free to throw anything at kyle@github.com that you want (rants appreciated)
Mizza 16y ago
What features in Kiln and Fogbugz? I use JIRA at work.. bleeeeeeeggggghhhh.

icco 16y ago

This is the final straw. I've been considering convincing my work to switch to git + GitHub, but I've just written up my proposal and I'm pitching it tomorrow, this is too awesome to pass up.

eru 16y ago
Please post your experiences. Some co-workers and me are considering a similar pitch.

newobj 16y ago

Github is just so awesome. They really nailed making code social. You really get the feeling of participating in a living, breathing thing with Github. It compels you to collaborate. It's frictionless. Every other hosted RCS just feels hopelessly static, a step above a download.com.