13 ms·

This is a bit western centric maybe, because I see Chinese developers reading tons of code, to the point that I receive an incredible amount of Redis PRs about

This is a bit western centric maybe, because I see Chinese developers reading tons of code, to the point that I receive an incredible amount of Redis PRs about conceptual bugs that can never happen in practice, since some Chinese developer is reading the code and doing the math in her/his head.

ralusek 9y ago
That's interesting, but also not so surprising. China has had decades of directing primary engineering/manufacturing efforts towards reverse engineering western products, or executing specific designs specified from western clients. The attitude of looking to someone else's engineering to learn from it is probably something the rest of us could do a bit more of.
heavenlyblue 9y ago
Any case you could share a link to one of these, if possible? A matter of curiosity.
- __s 9y ago
  First PR I saw on redis GH: https://github.com/antirez/redis/pull/4714 https://github.com/antirez/redis/pull/4714 That same user also made https://github.com/antirez/redis/pull/4685 https://github.com/antirez/redis/pull/4685 This may be? https://github.com/antirez/redis/pull/4622 https://github.com/antirez/redis/pull/4622 This was apparently critical, but also kind of an edgecase: https://github.com/antirez/redis/pull/4568 https://github.com/antirez/redis/pull/4568 & one more from someone else: https://github.com/antirez/redis/pull/4568 https://github.com/antirez/redis/pull/4568
- antirez 9y ago
  Probably soloestoy recently (but he also does a lot of Real world Redis) and Sun He in the past hold the records, but there are several...
stenecdote 9y ago
I wish one of these pull requesters would comment on this post! I'd love to hear how they're going about reading your code and whether they're actually using Redis or just reading it for enjoyment.
dtornabene 9y ago
I've heard similar things anecdotally from a developer that went to IIT in India. Had to read code first, with clarity, before they were able to sit down and code.

ralusek 9y ago

That's interesting, but also not so surprising. China has had decades of directing primary engineering/manufacturing efforts towards reverse engineering western products, or executing specific designs specified from western clients. The attitude of looking to someone else's engineering to learn from it is probably something the rest of us could do a bit more of.

heavenlyblue 9y ago

Any case you could share a link to one of these, if possible? A matter of curiosity.

__s 9y ago
First PR I saw on redis GH: https://github.com/antirez/redis/pull/4714 https://github.com/antirez/redis/pull/4714 That same user also made https://github.com/antirez/redis/pull/4685 https://github.com/antirez/redis/pull/4685 This may be? https://github.com/antirez/redis/pull/4622 https://github.com/antirez/redis/pull/4622 This was apparently critical, but also kind of an edgecase: https://github.com/antirez/redis/pull/4568 https://github.com/antirez/redis/pull/4568 & one more from someone else: https://github.com/antirez/redis/pull/4568 https://github.com/antirez/redis/pull/4568
antirez 9y ago
Probably soloestoy recently (but he also does a lot of Real world Redis) and Sun He in the past hold the records, but there are several...

stenecdote 9y ago

I wish one of these pull requesters would comment on this post! I'd love to hear how they're going about reading your code and whether they're actually using Redis or just reading it for enjoyment.

dtornabene 9y ago

I've heard similar things anecdotally from a developer that went to IIT in India. Had to read code first, with clarity, before they were able to sit down and code.