3 ms·

Not only does it not have any regression tests, it also fails the CI check, and it's already merged to the next branch. https://github.com/npm/npm/pull/19889 h

by lhorie 9y ago

Not only does it not have any regression tests, it also fails the CI check, and it's already merged to the next branch. https://github.com/npm/npm/pull/19889 https://github.com/npm/npm/pull/19889 This kind of thing disintegrates my confidence on npm as a project.

TheDong 9y ago
It, in fact, did pass the CI testing. The commit in question with the red X (7dff9d6) was pushed as a branch and then passed here [1]. After passing the test, the PR was made and merged, and the PR-test failed because it branch was already merged and travis-CI has races around that. [1]: https://travis-ci.org/npm/npm/builds/344892198?utm_source=github_status&utm_medium=notification https://travis-ci.org/npm/npm/builds/344892198?utm_source=gi...