3 ms·
IMO the mindset to be in when reviewing code is not one of evaluating whether it's correct, or even if it's written the way you would write it. Instead, ask yo
by cimmanom 9y ago
IMO the mindset to be in when reviewing code is not one of evaluating whether it's correct, or even if it's written the way you would write it.
Instead, ask yourself "how would I use this code?" How would you call it? How would you build on top of it? How would you maintain it?
If those things aren't clear, that's where to start asking questions and raising concerns.