3 ms·
Eh, half the benefit of code review on teams I've been on is just making the other engineers aware of what's going on. 75% of the code reviews are just a "good
by lovich 9y ago
Eh, half the benefit of code review on teams I've been on is just making the other engineers aware of what's going on. 75% of the code reviews are just a "good to go", the other 20% are questions about why a change was made that inform the other engineers about that particular business constraint, and the last 5% are actual issues.
As you said, it's completely different for junior engineers where it ends up being more like 90% bugs/tech debt, but the code reviews aren't all useless
- nojvek 9y ago100% - Most code reviews are. Why are you doing this? please add a comment. Wait! this will break this other thing in some obscure way. Or hey! I built this other thing over here, let's re-use it.