4 ms·

Loved this. And I agree with most of it. One thing I disagree with (and I know this puts me in the minority) is code review. Code review for trusted engineers

Loved this. And I agree with most of it. One thing I disagree with (and I know this puts me in the minority) is code review. Code review for trusted engineers is a waste of time. You're only going to find those bugs that are very hard to see. And the odds of you catching them in code review are very low. Also, if you're a kind of fast moving startup (like my company is) there's so much new code coming through that it is a serious slowdown to review it all. At least at the level where you'd need to if you're going to catch the things that the original author missed. I only make juniors and new hires do code reviews. I'll also ask for code reviews if an engineer is taking on a task that's totally new for them. But otherwise we've totally cut them out and been fine.

lovich 9y ago
Eh, half the benefit of code review on teams I've been on is just making the other engineers aware of what's going on. 75% of the code reviews are just a "good to go", the other 20% are questions about why a change was made that inform the other engineers about that particular business constraint, and the last 5% are actual issues. As you said, it's completely different for junior engineers where it ends up being more like 90% bugs/tech debt, but the code reviews aren't all useless
- nojvek 9y ago
  100% - Most code reviews are. Why are you doing this? please add a comment. Wait! this will break this other thing in some obscure way. Or hey! I built this other thing over here, let's re-use it.
ndh2 9y ago
In my opinion the main benefit of code review is diffusion of knowledge. It's kind of pointless to let new hires do reviews.
- methodover 9y ago
  What knowledge, specifically?