4 ms·
Interesting. Do you have candidates review code?
by dbcurtis 9y ago
Interesting. Do you have candidates review code?
- owyn 9y agoI have done this. Print out a page of code and review it with a candidate. Have them explain what it does, or how they might go about figuring that out, and what kinds of improvements they might make. Include some glaring bugs or code style problems if you want to ask those sorts of questions. I feel like small fragments of code work well for refactoring questions, whole programs tend to have a bunch of boiler plate code, but going over a bigger program to find the real core features quickly is also a valuable skill. I've done this with SQL too. Printed out a real statement from an application and ask about performance, optimization, what the application might be doing, etc. Or load a 100,000k line application in their favorite editor and ask "okay, try to find the frobzing subsystem, I want to know how it frobz bazzes". (I haven't done this yet...)
- rowyourboat 9y agoI have and it has, so far, never mislead.
- Zxian 9y agoWe have a sample repository with a simple, but broken, web application. We ask our candidates to review the code as they would if a coworker had submitted it as a merge request. it gives quite a bit of insight about what aspects they latch onto as issues of note. Do they catch the insidious, subtle issues or just the low hanging fruit? Do they understand what stdlib function arguments expect as input? Do they just pass your review through a linter and call it a day?