4 ms·

Seeing `puppeteer` in the example makes me feel odd about this. Isn't it an official Google project by paid Google employees? Eg I thought Paul Irish was a pai

Seeing `puppeteer` in the example makes me feel odd about this. Isn't it an official Google project by paid Google employees? Eg I thought Paul Irish was a paid Goole employeee, so it seems odd to suggest donating money to him in the context? (I might be wrong; and am also very thankful for what he does and don't begrudge anyone donating him money nor him asking for it. Just... Odd...)

feross 9y ago
So, that's my fault. To get things started, I added a bunch of authors who had accounts on Patreon and Librepay so `thanks` wouldn't start out completely empty. Specifically, I used the "Find My Friends" feature and just used the list that came up. (Paul had a LibrePay account receiving $0/month.) So, in the specific case of Paul it might not make sense to suggest donating to him for a Google project. Though, to be fair, he has a lot of packages on npm, some of which appear to be his own work (https://www.npmjs.com/~paulirish https://www.npmjs.com/~paulirish), so suggesting that you donate to him for time he's put into his own packages outside of work is fine in my book. The broader question is: how should we determine who to donate to? We could have packages declare explicitly if they're seeking donations and, if so, who to donate to. There's a proposal to do this here: https://github.com/feross/thanks/issues/2 https://github.com/feross/thanks/issues/2. For simplicity in this V1 product, I just used the list of maintainers who had npm publish permission at the time of the last release. As a concrete example, take a look at this JSON response from the registry: http://registry.npmjs.com/standard/latest http://registry.npmjs.com/standard/latest We're just using the list of users in the "maintainers" key. If any of those users is in this list (https://github.com/feross/thanks/blob/master/index.js https://github.com/feross/thanks/blob/master/index.js) then we suggest donating to them. Open to suggestions if you have better ideas.
- hawski 9y ago
  Maybe there could be a standard DONATIONS or FUNDING file alongside LICENSE and friends.
- aepiepaey 9y ago
  Use the couchdb instance at https://skimdb.npmjs.com/registry https://skimdb.npmjs.com/registry to scrape all readmes, parse them for URLs to known donation services, and seed the db using that. https://skimdb.npmjs.com/registry/_all_docs https://skimdb.npmjs.com/registry/_all_docs will return a list including the project IDs, then you can send a GET to https://skimdb.npmjs.com/registry/<id> https://skimdb.npmjs.com/registry/<id>, which returns a json object which includes the readme. For projects on Github, you could use OAuth to verify that a user owns a repo, and let them manually submit a donation URL. Not sure if npm provides OAuth, but if it does, use that instead.
paulirish 9y ago
Totally agree. Also, to Feross's comment below, I'm not an active developer on puppeteer, but I do have publish rights. :) Feross already sorted this out and nuked me from the list, which is 100% fine with me. Thanks for making the comment.
- feross 9y ago
  Perfect <3

feross 9y ago

So, that's my fault. To get things started, I added a bunch of authors who had accounts on Patreon and Librepay so `thanks` wouldn't start out completely empty. Specifically, I used the "Find My Friends" feature and just used the list that came up. (Paul had a LibrePay account receiving $0/month.) So, in the specific case of Paul it might not make sense to suggest donating to him for a Google project. Though, to be fair, he has a lot of packages on npm, some of which appear to be his own work (https://www.npmjs.com/~paulirish https://www.npmjs.com/~paulirish), so suggesting that you donate to him for time he's put into his own packages outside of work is fine in my book. The broader question is: how should we determine who to donate to? We could have packages declare explicitly if they're seeking donations and, if so, who to donate to. There's a proposal to do this here: https://github.com/feross/thanks/issues/2 https://github.com/feross/thanks/issues/2. For simplicity in this V1 product, I just used the list of maintainers who had npm publish permission at the time of the last release. As a concrete example, take a look at this JSON response from the registry: http://registry.npmjs.com/standard/latest http://registry.npmjs.com/standard/latest We're just using the list of users in the "maintainers" key. If any of those users is in this list (https://github.com/feross/thanks/blob/master/index.js https://github.com/feross/thanks/blob/master/index.js) then we suggest donating to them. Open to suggestions if you have better ideas.

hawski 9y ago
Maybe there could be a standard DONATIONS or FUNDING file alongside LICENSE and friends.
aepiepaey 9y ago
Use the couchdb instance at https://skimdb.npmjs.com/registry https://skimdb.npmjs.com/registry to scrape all readmes, parse them for URLs to known donation services, and seed the db using that. https://skimdb.npmjs.com/registry/_all_docs https://skimdb.npmjs.com/registry/_all_docs will return a list including the project IDs, then you can send a GET to https://skimdb.npmjs.com/registry/<id> https://skimdb.npmjs.com/registry/<id>, which returns a json object which includes the readme. For projects on Github, you could use OAuth to verify that a user owns a repo, and let them manually submit a donation URL. Not sure if npm provides OAuth, but if it does, use that instead.

paulirish 9y ago

Totally agree. Also, to Feross's comment below, I'm not an active developer on puppeteer, but I do have publish rights. :) Feross already sorted this out and nuked me from the list, which is 100% fine with me. Thanks for making the comment.

feross 9y ago
Perfect <3