4 ms·
>Also, I don't find those comments terrible. If anything, maybe a bit childish. I think it indicates that the people writing them felt comfortable enough with
by dsfyu404ed 9y ago
>Also, I don't find those comments terrible. If anything, maybe a bit childish.
I think it indicates that the people writing them felt comfortable enough with their environment team that they could talk freely.
Stuff like:
"if this alert fires you should start an incident and page teams X Y and Z before you page $alert_author."
"if this alert fires and we're not switching between active and standby data-centers then you should update your resume and begin the process of failing over to the standby datacenter"
"this is a terrible hack because this is a terrible legacy system and the worse it is the more incentive the remaining (internal) customers have to move to the new system and the author's time is better spend building good code for the current system"
"this process is specifically designed to be a massive pain in the ass in order to encourage you to do $stuff ahead of time and not rush it through in the last minute"
- dkersten 9y ago> people writing them felt comfortable enough with their environment team that they could talk freely. There's talking freely and there's writing childish or unprofessional comments in the source code. It doesn't take much to keep code comments clean and you can still vent to your coworkers in other ways. The example comments you wrote all seem ok to me though, except the second one, which just comes across childish or dickish. You can say the same thing and be blunt about it without suggesting someone should be fired for doing what you don't want them to do. But hey, that's just my opinion on the matter.