3 ms·
Please don't complain about old code not written to today's standards. There are reasons why code can be bad and you don't know what they are. Accept the code i
by onion2k 9y ago
Please don't complain about old code not written to today's standards. There are reasons why code can be bad and you don't know what they are. Accept the code is what it is, improve it where you can, and learn something about the crap a developer before you have had to go through when they wrote it. Even the worst hacks often aren't because they were a bad developer.
You'll have your share of terrible projects that force you to write horrible code without decent requirements to unreasonable deadlines for a client that won't listen. You'll hate what you write. You'll always want to go back and rewrite it but you'll never have the budget. You might quit your job over it. It certainly won't be a reflection of your skill or passion for writing great code. The "ancient PHP code" you're working with now probably isn't a reflection of the developer who wrote it either.
- space_fountain 9y agoYou're definitely right. My point got a little side tracked by my own partially unfounded frustration. I'm just trying to say some level of abstraction is worth it. Not always, and not in every case, but at least in some. Yes the code wasn't written with abstraction in large part because it's old, but it would have been better if it had been.
- crpatino 9y agoWe knew all about abstraction before PHP even existed. And I am told they knew all about abstraction before C and Unix existed. This knowledge did not prevent the arise of countless hairballs. You will not do better because, in retrospective, the forces that spawn the mudpiles have never been technical to begin with.