3 ms·

Initial commit: http://github.com/facebook/three20/commit/0edd0ca58bf3b352e7ab4b001c3470a8c1b70ae5 http://github.com/facebook/three20/commit/0edd0ca58bf3b352e7.

by mtigas 16y ago

Initial commit: http://github.com/facebook/three20/commit/0edd0ca58bf3b352e7ab4b001c3470a8c1b70ae5 http://github.com/facebook/three20/commit/0edd0ca58bf3b352e7... jverkoey looks to have implemented this himself. Actually, looking back through the network graph (http://github.com/facebook/three20/network http://github.com/facebook/three20/network) and commit log (http://github.com/facebook/three20/commits/master http://github.com/facebook/three20/commits/master) there really aren't ANY credits regarding merged-in patches or other contributions.

mtigas 16y ago
I take that back: There are rare commits such as http://github.com/facebook/three20/commit/807dbda1c8cb85f09b98767de67ca7d7454b4fbf http://github.com/facebook/three20/commit/807dbda1c8cb85f09b... which explicitly credit an author for the patch. <del>I hate to say it, but the current system (i.e. all commits through jverkoey) has the major drawback of putting code accountability in nobody's hands but Joey's.</del> --- Rescinded: http://github.com/facebook/three20/blob/master/CHANGES#L93 http://github.com/facebook/three20/blob/master/CHANGES#L93
- uxp 16y ago
  It's nothing more than Jeff Verkoeyen being the gatekeeper for the project's repo, the same way a tightly controlled SVN repo might be. He's supposed to review every line of code that goes into it, and the commit it himself. But everyone knows thats a daunting task, and theres no reason to review a simple thing like this to question where it originally came from. Right? Git is awesome, because it helps prevent these situations, but it's only a tool. Different people will use it differently, and based on the comments of the blog post, once he found out that it was copyrighted code, he rectified the problem. http://github.com/facebook/three20/commit/204673eea141acf4ee5f05402db6051dafcc8b17 http://github.com/facebook/three20/commit/204673eea141acf4ee... I'm not trying to pass blame, but I do believe that jverkoey never had the intention of stealing this code. None the less, Facebook.app ended up on the sour end of a situation they could have solved months ago, but they had no idea there was a problem until now.

by mtigas 16y ago

mtigas 16y ago

I take that back: There are rare commits such as http://github.com/facebook/three20/commit/807dbda1c8cb85f09b98767de67ca7d7454b4fbf http://github.com/facebook/three20/commit/807dbda1c8cb85f09b... which explicitly credit an author for the patch. <del>I hate to say it, but the current system (i.e. all commits through jverkoey) has the major drawback of putting code accountability in nobody's hands but Joey's.</del> --- Rescinded: http://github.com/facebook/three20/blob/master/CHANGES#L93 http://github.com/facebook/three20/blob/master/CHANGES#L93

uxp 16y ago
It's nothing more than Jeff Verkoeyen being the gatekeeper for the project's repo, the same way a tightly controlled SVN repo might be. He's supposed to review every line of code that goes into it, and the commit it himself. But everyone knows thats a daunting task, and theres no reason to review a simple thing like this to question where it originally came from. Right? Git is awesome, because it helps prevent these situations, but it's only a tool. Different people will use it differently, and based on the comments of the blog post, once he found out that it was copyrighted code, he rectified the problem. http://github.com/facebook/three20/commit/204673eea141acf4ee5f05402db6051dafcc8b17 http://github.com/facebook/three20/commit/204673eea141acf4ee... I'm not trying to pass blame, but I do believe that jverkoey never had the intention of stealing this code. None the less, Facebook.app ended up on the sour end of a situation they could have solved months ago, but they had no idea there was a problem until now.