4 ms·
(a) "transgressions", not transgressions. (b) I am not going to break it down for you like that, because that would not be useful, missing the forest for the t
by mpweiher 9y ago
(a) "transgressions", not transgressions.
(b) I am not going to break it down for you like that, because that would not be useful, missing the forest for the trees.
I think the whole approach of the article is mistaken and harmful, particularly stated as absolutely, "toxically" and without evidence as it is.
I've participated in code-reviews in roles as contributor, manager and mentor, with widely different teams in a variety of companies. The best teams that produced the best code were the ones that were the most "ruthless". Now of course: "hard on problems/code, soft on people", but with the first part being the priority.
Because the machine doesn't care about your feelings, and if you screwed up, you don't benefit from not being told that you screwed up.
And by tightly constraining the format to "helpful suggestion", you lose the range of feedback, from "awesome" via "yeah whatever" or "maybe try this" to "nope" and "what on earth were you thinking?".
Because it's important to not forget that the range always exists, compressing it into a lossy channel just muddles it.
Good teams have the rapport that makes the entire range of feedback possible and helpful. If that's not possible, it's an indication of a problem in the team. The more I am exposed to those sorts of teams, the more "toxic" I feel they are.
It also incorrectly shifts responsibility for negative feedback from the cause (the bad code) to the bearers of the bad news, and with it the burden for avoiding it. In order to avoid negative emotions due to negative feedback, don't police the feedback, write better code!
(Of course that assumes the feedback is roughly appropriate and proportional, a nuance that the article completely misses)
And once again, that has to be tempered with your role. As a manager, for example, it is important to take yourself back a bit, to let people code in their style even if you think you can do better (and particularly if you know you can). As a mentor, on the other hand, you are specifically there to help people grow, so comments at the level of "yes, you could do it this way, but I think this might be better" are more called for, because they are there as helpful guidance, without the implication of "you must do it or else" that goes with the formal power position (and will be understood that way even if you don't mean it).
And the most important part is fostering a team culture where there is a level of trust that feedback can be as harsh as necessary, where people actually want the toughest possible feedback. To create the best code and the best coders.
See also: The Coddling of the American Mind https://www.theatlantic.com/magazine/archive/2015/09/the-coddling-of-the-american-mind/399356/ https://www.theatlantic.com/magazine/archive/2015/09/the-cod...
- burntsushi 9y agoI will say that my comment was an attempt at making your concerns more concrete because they honestly don't make a lot of sense to me, but I feel like you just made them even more abstract. Based on the content of your comment and the seeming certainty of your opinions, I suspect we probably couldn't disagree more.
- mpweiher 9y agoI have made things more concrete, just not torn it into little unrecognizable micro-fragments that miss the point. Can you be more concrete as to what you disagree with? So far, you have said nothing of substance, just asked me to do the work for you and then made a broad and dismissive claim.
- burntsushi 9y agoI was interested in an answer to my question to understand your perspective. You won't give me an answer. That's okay, but so is my desire to set parameters on conversations that I engage in.
- mpweiher 9y agoThose two are contradictory: the answers to your very constrained questions would not have given you my perspective. My answer gave you my perspective. Anyway, I don't let others dictate "parameters" to me...as that is not a conversation. And as far as I can see, you are part of this problem.