3 ms·
I have the exact opposite opinion and experience. I think these are hard problems to solve. We haven't solved them yet; the need for this sort of article is e
by kelnos 9y ago
I have the exact opposite opinion and experience.
I think these are hard problems to solve. We haven't solved them yet; the need for this sort of article is empirical evidence of that. Toxic review behavior continues to be a problem.
I think face-to-face code reviews are much easier, because when you're sitting across from a real human, you pay much more attention to the social aspects of the interaction than when you're hiding behind a screen. You can also adjust your manner, tone, and word choice in real time based on the verbal and non-verbal cues you get from being physically present with the person you're talking to.
- austincheney 9y agoI completely disagree. Listening to people is paramount, but the subject of the conversation is the code in review. If you are paying more attention to the communication than the code you have lost focus and are reviewing communication opposed to code. I have been through this when people get hostile or defensive. They make their communication more important than the code. I don't have to deal with any of that online. As a project maintainer if somebody is being hostile I have several ways to deal with them from a command perspective. If I am a contributor and the project maintainer is being hostile then I simply won't contribute to that project. Also, online there is the convenience of time. You can take as long as you need to draft a proper well thought out response. Speed of thought in offline communication can cloud judgement and impose emotional distractions.
- kelnos 9y agoIf you believe that how you communicate is irrelevant, then I don't think we're going to have a productive discussion here. Because it does matter, as much as you or anyone (or even I) think it shouldn't.
- austincheney 9y agoI believe I described communication as paramount.