3 ms·
> The most toxic behavior is being overly protective or offended about your code. I disagree with "most", but this is absolutely often an issue. Often people
by kelnos 9y ago
> The most toxic behavior is being overly protective or offended about your code.
I disagree with "most", but this is absolutely often an issue. Often people take criticism of their code as criticism of themselves and their abilities, which is always counterproductive.
> As a general rule I think there is too much emotion in what should be 100% technically driven.
In my experience, things that are 100% technically driven are vanishingly rare. Most decisions come down to balancing trade offs and opinions, after examining the actual facts and evidence at hand.
Regardless, people have emotions and don't always act fully rationally, despite concerted efforts to do so. That's just a fact of human nature, and we'd do well to design our professional processes with that in mind.
- thedz 9y ago> I disagree with "most", but this is absolutely often an issue. Often people take criticism of their code as criticism of themselves and their abilities, which is always counterproductive. I think it's easy to fall into "this comment is a value judgement on my skill/person, and not my code" if code review feedback is targeted at the person and not the code. Hence the discouraged "why did you do this" form vs the more helpful "this might be better because" format.