3 ms·
I think it’s far better to develop a culture where code reviews are opinions and suggestions and if you disagree you can reply to a comment and discuss further.
by TimPC 9y ago
I think it’s far better to develop a culture where code reviews are opinions and suggestions and if you disagree you can reply to a comment and discuss further. Using aggressive tone is not helpful for this, but documentation needed to correct any mistake is unhelpful as well. If it’s hard to ask for additional information or hard to disagree with a review comment that isn’t going to be solved by increasing the quality of review comments. In fact I’m more likely to be upset if I make a mistake in my code and someone assumes it’s intentional, explains why it’s a mistake, and then provides documentation to explain further. That feels like in bold, triple underline, all-caps text to me. From my perspective a better comment might be “Let’s discuss further as I prefer alternative.” Highlighted on appropriate line of code with a this made issue specific. A lot of the time the reaction will be ‘oh, oops, so do I.’ The other times you spend the time on a discussion rather than carefully crafting a written statement (which is far more time consuming).