3 ms·
I find that focusing on negative behaviors and "what not to do" can have some undesired side effects. Namely, discouraging people from communicating because the
by darkerside 9y ago
I find that focusing on negative behaviors and "what not to do" can have some undesired side effects. Namely, discouraging people from communicating because they don't want to hurt someone's feelings or undervalue their own ideas. If you want to leave a comment, there's probably a great reason! Shutting yourself down does nobody any favors. I liked that there were a few ideas about helpful behaviors at the bottom, but they were less detailed and didn't include examples in the same way.
Over-communicate, notice positives, and build a culture of trust, where feedback is seen as the gift that it is. Those are the secrets to great code reviews... IMO
- TimPC 9y agoI think it’s far better to develop a culture where code reviews are opinions and suggestions and if you disagree you can reply to a comment and discuss further. Using aggressive tone is not helpful for this, but documentation needed to correct any mistake is unhelpful as well. If it’s hard to ask for additional information or hard to disagree with a review comment that isn’t going to be solved by increasing the quality of review comments. In fact I’m more likely to be upset if I make a mistake in my code and someone assumes it’s intentional, explains why it’s a mistake, and then provides documentation to explain further. That feels like in bold, triple underline, all-caps text to me. From my perspective a better comment might be “Let’s discuss further as I prefer alternative.” Highlighted on appropriate line of code with a this made issue specific. A lot of the time the reaction will be ‘oh, oops, so do I.’ The other times you spend the time on a discussion rather than carefully crafting a written statement (which is far more time consuming).