5 ms·
Naw, that error is the easiest way to spot Chrome only developers. Webkit provides the global event symbol within an event handler (old IE behavior). With Firef
by nathancahill 9y ago
Naw, that error is the easiest way to spot Chrome only developers. Webkit provides the global event symbol within an event handler (old IE behavior). With Firefox, you must explicitly pass an event variable. The difference between:
onClick () { event.doSomething() }
vs
onClick (e) { e.doSomething() }
The error isn't firing from the Nerv library, it's from their usage of it on the marketing site.
- city41 9y agoI'd still say it's a red flag. The developers of a browser library didn't test their site in Firefox. Makes me wonder if they tested the library in Firefox. Nerv is a library that wants to take an absolutely critical role in my app, I need to feel extremely confident choosing it.
- nathancahill 9y agoSure, it's a flag, but Nerv does have a test suite (with 96% coverage) that proves it runs across all browsers. I'm sure the marketing site does not have a test suite like that. You can't hold it to the same bar.
- city41 9y agoThat's fair. I'm just giving honest feedback. I understand Nerv is open source and not being built by a large entity like Facebook. It's also likely a nice library. So sure, I should cut them some slack. But at the same time, there's a lot of React clones to choose from, and seeing a simple error like this right out of the gate is off putting.
- erk__ 9y agoOn the other hand it looks like it is being at least sponsered by JD.com [0] which is a big chinese company [1] [0] https://jd.com/ https://jd.com/ [1] https://en.wikipedia.org/wiki/JD.com https://en.wikipedia.org/wiki/JD.com