5 ms·
Not sure that many OSS projects are going to be interested in merging a patch where a conversation with the patch author for review/feedback can't happen
by houli 9y ago
Not sure that many OSS projects are going to be interested in merging a patch where a conversation with the patch author for review/feedback can't happen
- analogj 9y agoI get that, but at the same time, there's a ton of reasons why a developer might not want their name attached to a bunch of code. As a maintainer myself, I can respect that. If the PR is important enough, I'm more than happy to merge it without knowing the author (with some additional tweaking if necessary).
- Walkman 9y agoCan you tell me one real example of why somebody would do that? I mean REAL, not some random reason you just think of.
- deanclatworthy 9y agoLegally questionable projects. There's plenty of projects on github which can be used for nefarious purposes with disclaimers that it shouldn't be used as such.
- Sir_Substance 9y agoEh, you'd be surprised. Big projects? no. But I sometimes submit patches to small projects that I've integrated into personal projects, and pretty much every patch I've ever submitted has been accepted without comment. I set my git username and email to "<>" at the global level, which completely breaks githubs UI, and people /still/ accept the pull requests.