4 ms·

Perhaps an IDE/editor that autoformats python code?

by felbane 9y ago

ci5er 9y ago
I am now more than a little embarrassed that this didn't even occur to me...
- arthulia 9y ago
  It doesn't make a whole ton of sense because you'd still need to know when to un-indent in order to get out of a conditional block. IDEs can't read your mind.
  - reificator 9y ago
    I've never asked the details, I just know that they used Python before but couldn't cope with indentation when I worked with them on code.
    - AlexCoventry 9y ago
      How did they fail to cope with it?
      - reificator 9y ago
        I had an answer typed up, but it felt like picking on them rather than explaining the issue. Text is hard. After submitting changes that started 10 indents past the previous line, and had little to no rhyme or reason for subsequent indentation, we asked them to reformat and resubmit. When it became clear that they could not, we reviewed the code itself separately from the indentation and reformatted it ourselves. Multiple co-workers sat next to them to try to explain how to line things up vertically, but they were unable to do so without said help. This was over the course of about two weeks in which we were instructed to try to bring them onboard some of our projects. Both our and their projects at the time were frontend web projects. I have not looked at any of their code outside what was submitted to our side, but I do know they are praised for the quality of their work by management.
        AlexCoventry 9y ago
        Thanks. Interesting.
  - pferde 9y ago
    That's what they want you to think.
  - JetSpiegel 9y ago
    But they can auto-format copy-pasted code from Stack Overflow.
wprintf 9y ago
Actually, I used VIM on Windows while editing the files. My VIM is set with fixendofline or something. The files with the extra line ending change did not have \r\n at the end, so my VIM added it. I usually prefer to the have the extra line ending at the end of every file, so I kept the change in the PR.

Perhaps an IDE/editor that autoformats python code?

ci5er 9y ago

I am now more than a little embarrassed that this didn't even occur to me...

arthulia 9y ago
It doesn't make a whole ton of sense because you'd still need to know when to un-indent in order to get out of a conditional block. IDEs can't read your mind.
- reificator 9y ago
  I've never asked the details, I just know that they used Python before but couldn't cope with indentation when I worked with them on code.
  - AlexCoventry 9y ago
    How did they fail to cope with it?
    - reificator 9y ago
      I had an answer typed up, but it felt like picking on them rather than explaining the issue. Text is hard. After submitting changes that started 10 indents past the previous line, and had little to no rhyme or reason for subsequent indentation, we asked them to reformat and resubmit. When it became clear that they could not, we reviewed the code itself separately from the indentation and reformatted it ourselves. Multiple co-workers sat next to them to try to explain how to line things up vertically, but they were unable to do so without said help. This was over the course of about two weeks in which we were instructed to try to bring them onboard some of our projects. Both our and their projects at the time were frontend web projects. I have not looked at any of their code outside what was submitted to our side, but I do know they are praised for the quality of their work by management.
      - AlexCoventry 9y ago
        Thanks. Interesting.
- pferde 9y ago
  That's what they want you to think.
- JetSpiegel 9y ago
  But they can auto-format copy-pasted code from Stack Overflow.

wprintf 9y ago

Actually, I used VIM on Windows while editing the files. My VIM is set with fixendofline or something. The files with the extra line ending change did not have \r\n at the end, so my VIM added it. I usually prefer to the have the extra line ending at the end of every file, so I kept the change in the PR.