2 ms·
> force pushing to the branch to take into account criticism on commits can be helpful Hm? Criticism on commits should be additive. The commit was made, respon
by jsmthrowaway 9y ago
> force pushing to the branch to take into account criticism on commits can be helpful
Hm? Criticism on commits should be additive. The commit was made, response was made, and a new commit addresses the response. Rewriting history breaks a lot of things and removes context. Another approach:
1) Add commit addressing criticism.
2) Squash when merging feature in to master, which is one of the only cases where I think rewriting history is OK.
Much cleaner master history, no rewriting history (which you should never do once another checkout sees your branch, including GitHub), and a number of other benefits. If you're routinely force pushing feature branches, something is broken in your workflow, IMO.