4 ms·

GitLab removed TurboLinks from their site not that long ago. It was the source of a lot of bugs, crufty code, and flakey tests. If you have any JavaScript that

GitLab removed TurboLinks from their site not that long ago. It was the source of a lot of bugs, crufty code, and flakey tests. If you have any JavaScript that modifies the DOM or ever plan to don’t use TurboLinks.

pbreit 9y ago
Shopify went back to Turbolinks: https://shopifyengineering.myshopify.com/blogs/engineering/rebuilding-the-shopify-admin-improving-developer-productivity-by-deleting-28-000-lines-of-javascript https://shopifyengineering.myshopify.com/blogs/engineering/r...
- deckar01 9y ago
  That article is from 2014, the golden age of TurboLinks. As far as I can tell they are not using it on their main site or any of their white labeled sites anymore. https://github.com/shopify-graveyard/turbolinks/ https://github.com/shopify-graveyard/turbolinks/
  - Rafert 9y ago
    They forked: https://github.com/Shopify/turbograft https://github.com/Shopify/turbograft to add partial page replacements. It was slated to be merged in TurboLinks 3 but that canned in favour of version 5. Their new Polaris components are using React though: https://github.com/shopify/polaris https://github.com/shopify/polaris
owens99 9y ago
> GitLab removed TurboLinks from their site not that long ago. It was the source of a lot of bugs, crufty code, and flakey tests. An anecdote is not data.
- deckar01 9y ago
  > Turbolinks.clearCache() Removes all entries from the Turbolinks page cache. Call this when state has changed on the server that may affect cached pages. https://github.com/turbolinks/turbolinks#turbolinksclearcache https://github.com/turbolinks/turbolinks#turbolinksclearcach... This is a nightmare. You will eventually miss a cache invalidation and break browser navigation or invalidate the cache so aggressively that TurboLinks is serving no purpose. You don't need lots of negative testimonials to see that managing your own client side cache with JavaScript is a bad idea.
  - owens99 9y ago
    Haven't had any problems with this in 2 years in production. It also works fine for Basecamp.

pbreit 9y ago

Shopify went back to Turbolinks: https://shopifyengineering.myshopify.com/blogs/engineering/rebuilding-the-shopify-admin-improving-developer-productivity-by-deleting-28-000-lines-of-javascript https://shopifyengineering.myshopify.com/blogs/engineering/r...

deckar01 9y ago
That article is from 2014, the golden age of TurboLinks. As far as I can tell they are not using it on their main site or any of their white labeled sites anymore. https://github.com/shopify-graveyard/turbolinks/ https://github.com/shopify-graveyard/turbolinks/
- Rafert 9y ago
  They forked: https://github.com/Shopify/turbograft https://github.com/Shopify/turbograft to add partial page replacements. It was slated to be merged in TurboLinks 3 but that canned in favour of version 5. Their new Polaris components are using React though: https://github.com/shopify/polaris https://github.com/shopify/polaris

owens99 9y ago

> GitLab removed TurboLinks from their site not that long ago. It was the source of a lot of bugs, crufty code, and flakey tests. An anecdote is not data.

deckar01 9y ago
> Turbolinks.clearCache() Removes all entries from the Turbolinks page cache. Call this when state has changed on the server that may affect cached pages. https://github.com/turbolinks/turbolinks#turbolinksclearcache https://github.com/turbolinks/turbolinks#turbolinksclearcach... This is a nightmare. You will eventually miss a cache invalidation and break browser navigation or invalidate the cache so aggressively that TurboLinks is serving no purpose. You don't need lots of negative testimonials to see that managing your own client side cache with JavaScript is a bad idea.
- owens99 9y ago
  Haven't had any problems with this in 2 years in production. It also works fine for Basecamp.