3 ms·
When seeing the link, I had hoped to read some general wisdom about the benefits of reviewing code or some advice about the best way to perform a code review, n
by fjfaase 9y ago
When seeing the link, I had hoped to read some general wisdom about the benefits of reviewing code or some advice about the best way to perform a code review, not some language specific remarks about Java usage.
- qznc 9y agoI made myself a checklist of reviewing pull requests to dlangs standard library. The only general item is "understood comments in code". The rest is specific. The section titles are kind of generic as they convey the aspects to consider: Code Gotchas, Documentation, Code Style, Unittests.