5 ms·
Very impressive! Works well, nice UI, informative. After doing a couple exercises what I don't like is the naming convention. Something like "montlymaintenance
by tekkk 9y ago
Very impressive! Works well, nice UI, informative.
After doing a couple exercises what I don't like is the naming convention. Something like "montlymaintenance" or "recommendedby" are just hard to read and type and I'd much rather use snake-case and/or shorter names. Eg. "monthly_maintenance" or "maintenance_per_month" or just "maintenance" if it's explicit enough that it's always per month.
Also to me using shorthands for ids is a bit hmm hmm I mean sure you write them a lot so it's useful to spare your fingers when typing queries but "facid" just seems wrong. Again maybe underscore? "fac_id" or even "facility_id".
Well that's at least my opinion. Also would it be a better practise to use "timestamptz" instead of "timestamp"? And FYI I had to zoom to 125% because the font was so small on my laptop.
- pinouchon 9y agoSame thing, took me a while to understand that facid was indeed facility_id. In my previous work, we used this to test candidates when their job involved writing SQL. Worked great.
- adwf 9y agoTimestamptz is better practice. Same size (8 bytes) on disk and saves you from headaches further down the line.
- AlisdairO 9y agoAuthor here - thanks a lot for the feedback, it's appreciated. You're right on the naming convention, it's very haphazard. I'll raise an issue on Github to revisit that - although it may take me quite a while to get to it as I have a two week old to look after right now :-).