4 ms·

No, tests are commonly in the same package as the implementation. I did find this one: https://github.com/tenta-browser/tenta-dns/blob/master/src/tenta-dns/run

No, tests are commonly in the same package as the implementation. I did find this one: https://github.com/tenta-browser/tenta-dns/blob/master/src/tenta-dns/runtime/limiter_test.go https://github.com/tenta-browser/tenta-dns/blob/master/src/t... That's an internal test, meaning it has access to the package internals. A better test would test from outside the boundaries of the package to only interact with exposed symbols.

alpb 9y ago
Oh lordy, that log.SetLogLevel() has effects outside the test code.
- tenta 9y ago
  Setting the log level has effects, but only on an internal wrapper package that neatly zips up the nitty gritty of setting up the logger.
  - sagichmal 9y ago
    Package-level loggers are an antipattern :(