3 ms·
Some suggestions: 1) I would make a better distinction between the function declaration and the program output. e.g: format the output differently. like gray.
by partycoder 9y ago
Some suggestions:
1) I would make a better distinction between the function declaration and the program output. e.g: format the output differently. like gray.
2) Capitalization. "InvalidWRTargError".
It would help if you could capitalize it as "InvalidWrtArgError". This is a guideline in most coding standards. https://en.wikipedia.org/wiki/Camel_case#In_abbreviations https://en.wikipedia.org/wiki/Camel_case#In_abbreviations
3) Better naming:
- "getNumericalForwardGradient": Are there non-numerical gradients?
- "applyGradientOnce": A function is applied once per invocation by convention.
Then it would be good if you formatted using PEP8, as it is standard in Python.
- sushantc 9y agoThanks partycoder! Points taken; will make some changes. Regarding numerical gradients, named it so to differentiate it from analytical gradients, which leverage formulas from calculus. The "numerical" ones are calculated using (f(x+h)-f(x))/h every time.
- ydidntithnkftht 9y agoPython community conventions are not camel case for functions... forwardAddGate would be forward_add_gate and return is not a function call... return(max(x,y)) or return(x+y) would be return max(x, y) or return x + y spaces around operators... x + y not x+y spaces around function args... def foo(a, b) not def foo(a,b) and when calling... foo(1, 2) not foo(1,2) https://www.python.org/dev/peps/pep-0008/ https://www.python.org/dev/peps/pep-0008/ Just things to think about when publishing python code for the greater community.
- partycoder 9y agoThere's a package that verifies PEP8 for you. https://pypi.python.org/pypi/pep8 https://pypi.python.org/pypi/pep8
- partycoder 9y agoI see the difference now, thanks for the clarification.