3 ms·
That's a good start! One bigger issue is you're storing built assets in source control. This is considered bad practice, as it creates a lot of noise in commit
by timdorr 9y ago
That's a good start!
One bigger issue is you're storing built assets in source control. This is considered bad practice, as it creates a lot of noise in commits and bogs down git clients with tons of unnecessary blobs. git is for source code, npm is for transpiled code and UMD bundles.
You should "retcon" your repo, by removing them from history with filter-branch (the same process as with sensitive data removal: https://help.github.com/articles/removing-sensitive-data-from-a-repository/ https://help.github.com/articles/removing-sensitive-data-fro...), make sure they're .gitignore'd, and only publish the built assets in your npm packages (use the "files" option in package.json).