4 ms·
> The patchset itself was broken and intermediate states didn't compile As a maintainer, isn't it then your right to refuse the patchset and demanding a clean
by vog 9y ago
> The patchset itself was broken and intermediate states didn't compile
As a maintainer, isn't it then your right to refuse the patchset and demanding a clean patchset instead?
- peterwaller 9y agoHe's a maintainer of bcache, not of block layer, where the problematic patchset was introduced.
- mlyle 9y agoAs pointed out elsewhere, I never accepted this patchset. But: For stuff I accept, I try and make sure that intermediate states compile, but I can't promise I run a compile on every intermediate step or that my review eye is good enough to spot every wrongly-ordered-dependent-change. It would be nice if someone would throw hardware at building intermediate states of linux-next and sent nastygrams to maintainers/committers about it: might make people more careful.
- vog 9y agoCan't you use GitHub's integrated TravisCI for that? At least that's what I know other Free Software projects are doing.
- mlyle 9y agoTravisCI generally tests the end result of a PR, not all intermediate states. I have a continuous integration tool for bcache in place, but it's more geared on end states-- compiling/checkpatch/test sequence.